-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(onboarding): Add logs empty state onboarding for python sdks #98010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
const logsOnboarding = getPythonLogsOnboarding({ | ||
basePackage: 'sentry-sdk[chalice]', | ||
} as any); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Package Name in Python Logs Onboarding
The getPythonLogsOnboarding
function is called with basePackage
instead of the expected packageName
. The as any
cast hides this type mismatch, causing the intended specialized package (like sentry-sdk[celery]
or sentry-sdk[chalice]
) to be ignored. As a result, the default sentry-sdk
is used instead.
Additional Locations (1)
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
resolves https://linear.app/getsentry/issue/LOGS-305/add-logs-onboarding-for-python-sdks
resolves https://linear.app/getsentry/issue/LOGS-248/add-logs-to-python-onboarding