feat(cmdk_v2): poc llm serv #98015
Merged
feat(cmdk_v2): poc llm serv #98015
+76
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Comment on lines
+22
to
+31
| const res = await fetch(url, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: JSON.stringify({ | ||
| query, | ||
| }), | ||
| }); | ||
| const data: LLMRoutingResult = await res.json(); |
There was a problem hiding this comment.
Potential bug: The fetch call in useLLMRoutingDynamicActions lacks error handling. A failed network request will throw an unhandled exception, crashing the OmniSearch component and making it unusable.
-
Description: The
attemptRouteQueryfunction in theuseLLMRoutingDynamicActionshook executes afetchrequest to an external service without atry...catchblock or any other form of error handling. If this network request fails due to network issues, the service being unavailable, or if the service returns a non-JSON response, thefetchorres.json()call will throw an unhandled error. Because this hook is called unconditionally during the render cycle of theOmniSearchPalette, the unhandled exception will propagate up and likely crash the component, rendering the application's primary search functionality unusable. -
Suggested fix: Wrap the
fetchcall and the subsequentawait res.json()within atry...catchblock inside theattemptRouteQueryfunction. In thecatchblock, handle the error gracefully, for instance by logging it and ensuring theextraRouteActionsstate is set to an empty array to prevent a crash.
severity: 0.7, confidence: 0.9
Did we get this right? 👍 / 👎 to inform future reviews.
|
|
||
| useEffect(() => { | ||
| attemptRouteQuery(); | ||
| }, [attemptRouteQuery]); |
There was a problem hiding this comment.
Bug: Fetch Errors and Query Race Condition
The attemptRouteQuery function lacks error handling for its fetch request and JSON parsing, potentially causing unhandled rejections and component instability. Rapid query changes also create a race condition, leading to stale results from older requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.