Skip to content
This repository was archived by the owner on Feb 25, 2022. It is now read-only.

feat: select different config via command line #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: select different config via command line #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ export
.cache
last_imported
config.yml
config-*.yml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering, maybe it would be nicer to introduce a config directory if there are multiple config files.

Maybe what could happen is:

  • the script looks for a config.yml by default and if it doesn't find any ./config.yml and no arguments are given, it throws an error explaining the two ways of configuring it
  • when an argument is given, it never checks for the ./config.yml, it could directly try to access config/your-argument.yml

What do you think?

I really like that idea, amazing that you started this PR!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Will have to look how to do this with Ruby. I am more a Python/Bash guy ;)

2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,4 +142,4 @@ DEPENDENCIES
ynab (= 1.5.0)

BUNDLED WITH
1.17.3
2.0.1
8 changes: 7 additions & 1 deletion lib/settings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ def self.all
if ENV['ENV'] == 'test'
YAML.load_file(File.join('.', 'spec/config.test.yml'))
else
YAML.load_file(File.join('.', 'config.yml'))
# check if the first command line parameter contains a value and use that for the config file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about the code a bit and what you could do is to extract all the config-file related logic to a method and then call it. Could be something like this:

# Reads the settings from the yaml file
class Settings
  def self.all
    @settings ||= begin
      YAML.load_file(File.join('.', config_path))
    end
  end

  def self.config_path
    return "spec/config.test.yml" if ENV['ENV'] == 'test'
    return "config/#{ARGV[0]}.yml" if ARGV[0]
    "config.yml"
  end
end

The YAML.load_file should already throw an understandable error, so I don't think we would need to handle it. Let me know what you think

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above - great idea but no idea how to do this in Ruby. Will have to look into it.

first_arg, *the_rest = ARGV
if !first_arg.to_s.strip.empty?
YAML.load_file(File.join('.', first_arg.to_s.strip))
else
YAML.load_file(File.join('.', 'config.yml'))
end
end
end
end
Expand Down