Bug Fix: store typescript_declarations config and rebuild if changed (Attempt 2) #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jun 16, 2025
| kind: FileKind::File, | ||
| path: ts_indicator_path, | ||
| err: Some(e.to_string()), | ||
| })?; |
There was a problem hiding this comment.
self.io.write already returns the right error type so can return it as-is without wrapping it in another layer.
| .paths | ||
| .build_directory_for_target(self.mode(), self.target()); | ||
|
|
||
| let ts_indicator_path = build_path.join("typescript-declarations.lock"); |
There was a problem hiding this comment.
This isn't a lock file so let's remove the .lock extension.
|
@lpil Addressed both comments. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New branch for bugfix related to #4523
Had a merge commit in my history but I am too scared of messing up my branch with rebasing, because I have no experience with that action.
File changes are identical though
FYI @lpil