Better error message for unknown variable named as an ignored variable #4686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jun 17, 2025
...r-core/src/type_/tests/snapshots/gleam_core__type___tests__errors__shadowed_fn_argument.snap
Outdated
Show resolved
Hide resolved
|
Why doesn't Github notify me when an issue I make has a PR marking it as fixed? Thanks so much for doing this! |
|
Everything should be fixed and ready now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a variable has the same name as an ignored variable the compiler can now show more context in the "unknown variable" error, pointing to the ignored variable.
This PR fixes #4512