feat: upgrade storybook #880
Conversation
|
Storybook Preview: https://615abff875b8f5004aa277ac-cqjomtlojn.chromatic.com/ |
finalight
force-pushed
the
feature/upgrade-storybook
branch
from
2bb0360 to
da9225a
Compare
finalight
force-pushed
the
feature/upgrade-storybook
branch
from
98e332e to
9281e5e
Compare
| docs: { | ||
| source: { | ||
| code: ` | ||
| const customActionGroup = ( | ||
| const CustomActionGroup = ( |
There was a problem hiding this comment.
storybook plugin dictates that PascalCase should be used
| @@ -87,7 +87,7 @@ export const ComboboxMultiSelect = ({ | |||
| }, [isSearchEmpty, options]); | |||
|
|
|||
| return ( | |||
| <div style={{ maxWidth: '500px' }}> | |||
| <div style={{ maxWidth: 500 }}> | |||
There was a problem hiding this comment.
i need to use non-unit number else it will have problem rendering this storybook
| @@ -76,13 +77,14 @@ export const ActivatorSelect = ({ | |||
| if (hasSelectedValues) { | |||
| return ( | |||
| <TagsContainer> | |||
| <StyledTag | |||
| <Tag | |||
| style={{ width: 28, marginRight: space8 }} | |||
There was a problem hiding this comment.
somehow it will have error rendering this page if we use styled component of Tag in this page
so i have to not use styled component instead assign a style like the above to the tag
There was a problem hiding this comment.
Hmmm can we investigate this more? I don't think we should update the implementations to cater storybook upgrade
| height: 28px; | ||
| margin-right: ${space8}; | ||
| `; | ||
| // export const StyledTag = styled(Tag)` |
There was a problem hiding this comment.
keeping this because of the above
There was a problem hiding this comment.
same comment as above
| @@ -17,8 +17,8 @@ Interactive.args = { | |||
| label: 'Description', | |||
| }; | |||
|
|
|||
| export const removeFloatingLabelIsTrue = Template.bind({}); | |||
| removeFloatingLabelIsTrue.args = { | |||
| export const RemoveFloatingLabelIsTrue = Template.bind({}); | |||
There was a problem hiding this comment.
storybook plugin dictates that PascalCase should be used
No description provided.