Skip to content

Run 'clean' before build #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

agibson-godaddy
Copy link
Contributor

@agibson-godaddy agibson-godaddy commented Apr 30, 2025

Summary

This update sthe workflow to run npm run clean before building. It seems occasionally when running npm run build the coffee assets aren't being compiled. This can be seen by looking at the commit column -- notice how some weren't changed!

Screenshot 2025-04-30 100543

After local testing I was able to reproduce those files not changing. They only finally changed by running npm run clean prior to building.

QA

  1. Run the "prep release" workflow from this branch. -- workflow run https://github.com/godaddy-wordpress/wc-plugin-framework/actions/runs/14751125116/job/41408663542
    • Resulting PR contains all modified dist/* js files.

Before merge

  • I have confirmed these changes in each supported minor WooCommerce version

@agibson-godaddy agibson-godaddy self-assigned this Apr 30, 2025
@agibson-godaddy
Copy link
Contributor Author

Here's a full list of modified files this time:

image

And here's the payment gateway form JS with the actual minified version:

image

@agibson-godaddy agibson-godaddy marked this pull request as ready for review April 30, 2025 09:20
@agibson-godaddy agibson-godaddy merged commit 4ca1357 into master Apr 30, 2025
6 checks passed
@agibson-godaddy agibson-godaddy deleted the chore/fix-workflow-to-clean-first branch April 30, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant