Add support for parsing "Command/Ctrl" in OS::find_keycode_from_string

[OzelotVanilla]

Let the function directly parse the shortcut such like "Command/Ctrl+S" to reduce the boilerplate code.

[timothyqiu]

Note that regex is an optional module.

It's probably not a good idea to make the core dependent on this module or to change the behavior depending on whether the module is enabled.

[OzelotVanilla]

Note that regex is an optional module.

It's probably not a good idea to make the core dependent on this module or to change the behavior depending on whether the module is enabled.

Got that, thank you. Let me try a different approach.

[OzelotVanilla]

I fixed it and now it is OK for review.

[AThousandShips]

Any reason this supports web iOS but not native iOS support?

[OzelotVanilla]

I copied from somewhere else, and I did not realised that. Will fix later, thank you for pointing it out !

[OzelotVanilla]

Currently I found that OS::get_name() or OS::get_identifier for lower case, returns the OS information, and I guess comparing them with "macos", "ios", "visionos", plus the has_feature compare of "web_macos" and "web_ios" (and also "web_visionos" ?), solves the problem.

Do you think adding a method in OS like is_apple_platform is better (worth making a PR) ?

• If so, I will rebase this PR after is_apple_platform is merged to master 😀.

[OzelotVanilla]

Also I found the doc doc/classes/OS.xml, lacks the "visionOS" one.

godot/doc/classes/OS.xml

Lines 372 to 383 in 9a39760

	<method name="get_name" qualifiers="const">
	<return type="String" />
	<description>
	Returns the name of the host platform.
	- On Windows, this is [code]"Windows"[/code].
	- On macOS, this is [code]"macOS"[/code].
	- On Linux-based operating systems, this is [code]"Linux"[/code].
	- On BSD-based operating systems, this is [code]"FreeBSD"[/code], [code]"NetBSD"[/code], [code]"OpenBSD"[/code], or [code]"BSD"[/code] as a fallback.
	- On Android, this is [code]"Android"[/code].
	- On iOS, this is [code]"iOS"[/code].
	- On Web, this is [code]"Web"[/code].
	[b]Note:[/b] Custom builds of the engine may support additional platforms, such as consoles, possibly returning other names.

which is implemented already:

godot/platform/visionos/os_visionos.mm

Lines 48 to 50 in 9a39760

	String OS_VisionOS::get_name() const {
	return "visionOS";
	}

Can I ask if it is by design, or ?

[OzelotVanilla]

And also the code I copied is from here:

godot/core/os/keyboard.cpp

Line 373 in 9a39760

if (OS::get_singleton()->has_feature("macos") || OS::get_singleton()->has_feature("web_macos") || OS::get_singleton()->has_feature("web_ios")) {

Should it also be changed to the apple-platform detection logic mentioned above ?

Looking forward to your reply 😀.