-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Couchbase support #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Couchbase support #2076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @olxandr ! A very well drafted PR. I would like you to also add docs with a docker container and a small code snippet. Refer how it is added for the others.
Other than that I would want you to also add screenshots of...... Logs Traces and metrics for a Db call. Would then test it in local and we will be good to go.
What surprised me is that in order to get the Couchbase ready to use, just spinning up the docker container isn't enough. You also need to go to Couchbase Web Console by visiting |
You can add the respective docs link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @olxandr !
A bit of info on the datasource setup in the docs would be appreciated.
@olxandr Please resolve the linter issues in your PR. Thankyou! |
The
Any suggestions on how to deal with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me.
Closes #1997
Description:
This PR is adding a native support for Couchbase.
The official github.com/couchbase/gocb/v2 Go Couchbase library is introduced as a dependency for this PR.
Checklist:
goimport
andgolangci-lint
.