Skip to content

docs: Add JSDoc examples for AgentProvider and AgentExtension interfaces #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZapzCsgo
Copy link

Add missing JSDoc @example annotations to AgentProvider and AgentExtension interfaces to improve TypeScript developer experience.

Examples use Google ecosystem references (ai.google.dev, OAuth 2.0) and follow existing JSDoc patterns in the codebase.

First contribution to open source ❤️

@ZapzCsgo ZapzCsgo requested a review from a team as a code owner June 15, 2025 00:12
@holtskinner
Copy link
Collaborator

@pstephengoogle I'm in favor of adding this, however these examples don't get ported into the a2a.json file or any other types files.

@ZapzCsgo
Copy link
Author

@pstephengoogle I'm in favor of adding this, however these examples don't get ported into the a2a.json file or any other types files.

Thanks for the feedback, I will check this evening the integration of the examples in a2a.json and in the other type files so that it is clean

@ZapzCsgo
Copy link
Author

ZapzCsgo commented Jun 16, 2025

After digging, I found that this is not feasible given the current project architecture. I misunderstood your statement about A2A generation in your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants