-
Notifications
You must be signed in to change notification settings - Fork 281
Add Arm64 Windows CI support, CMake #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@gchatelet, @Mizux, PR is ready to review |
@@ -0,0 +1,26 @@ | |||
# ref: https://github.com/actions/runner-images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to replace by this url https://github.com/actions/partner-runner-images
pull_request: | ||
schedule: | ||
# min hours day(month) month day(week) | ||
- cron: '0 0 7,22 * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add workflow_dispatch:
too to be able to run it manually ?
|
||
jobs: | ||
# Building using the github runner environement directly. | ||
make: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename it cmake
.
I think on windows most features flag are not populated.... cpu_features/test/cpuinfo_aarch64_test.cc Lines 126 to 137 in d3b2440
cf:
vs https://github.com/google/cpu_features/blob/main/src/impl_aarch64_windows.c |
Github actions added support Windows Arm64 for public repositories with runner name
windows-11-arm
:Cmake has known issue related to build for Windows Arm64.
CMAKE_SYSTEM_PROCESSOR
on Arm64 target showsAMD64
...Issue discussion:
So
CMAKE_<LANG>_COMPILER_ARCHITECTURE_ID
must be used to setPROCESSOR_IS_AARCH64
architecture:Also, currently we have build fail for windows Arm64, I think it should be fixed as separate patch:
LINE
features from src/impl_aarch64__base_implementation.inl#L31We can't use "define_introspection_and_hwcaps.inl" as a common file for all operating systems due to msvc compiler error C2099: initializer is not a constant, so as a workaround for Windows I used separate "define_introspection.inl"