Fixing formatting #4874
Open
Fixing formatting #4874
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bullets weren't bullets
8bitmp3
reviewed
Aug 6, 2025
| * It changes the checkpoint structure, as each layer will have unique RNG state. | ||
| * It changes how ``nnx.split_rngs`` interacts with transforms like ``nnx.vmap`` and ``nnx.scan``, | ||
| as the resulting RNG state will now not be stored in scalar form. | ||
| * It changes how ``nnx.split_rngs`` interacts with transforms like ``nnx.vmap`` and ``nnx.scan``, as the resulting RNG state will now not be stored in scalar form. |
There was a problem hiding this comment.
Nit:
Suggested change
| * It changes how ``nnx.split_rngs`` interacts with transforms like ``nnx.vmap`` and ``nnx.scan``, as the resulting RNG state will now not be stored in scalar form. | |
| * It changes how ``nnx.split_rngs`` interacts with transforms like ``nnx.vmap`` and ``nnx.scan``, as the resulting PRNG state will now not be stored in scalar form. |
8bitmp3
reviewed
Aug 6, 2025
| @@ -11,9 +11,9 @@ Using Rngs in NNX Transforms | |||
| NNX layers that use RNGs like Dropout or MultiHeadAttention now hold a ``fork``-ed copy of the ``Rngs`` | |||
| object given at construction time instead of a shared reference to the original ``Rngs`` object. This has | |||
| two consequences: | |||
|
|
|||
| * It changes the checkpoint structure, as each layer will have unique RNG state. | |||
There was a problem hiding this comment.
Nit:
Suggested change
| * It changes the checkpoint structure, as each layer will have unique RNG state. | |
| * It changes the checkpoint structure, as each layer will have a unique PRNG state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bullets weren't bullets
What does this PR do?
Fixes # (issue)
Checklist
checks if that's the case).
discussion (please add a
link).
documentation guidelines.
(No quality testing = no merge!)