Added version check through Remote Config #3150
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandwana001
changed the title
shobhitagarwal1612
requested changes
May 29, 2025
shobhitagarwal1612
requested changes
Jun 4, 2025
|
one test is failing when running - signInProgressDialog_whenSignedOutAfterSignInState_isNotDisplayed |
app/src/main/java/org/groundplatform/android/GroundApplication.kt
Outdated
Show resolved
Hide resolved
|
The UI for this dialog looks a bit different from the rest of the app. Can we make it consistent? |
As discussed earlier in meeting, we will be doing the UI UX stuff as soon as we get the design. For this, the font, styles colors are matching |
|
yes, it is only failing here, not sure why, looking into this |
…orce-version-update # Conflicts: # app/src/main/java/org/groundplatform/android/GroundApplication.kt # app/src/main/res/values-es/strings.xml # app/src/main/res/values-fr/strings.xml # app/src/main/res/values-pt/strings.xml # app/src/main/res/values/strings.xml
…update' into anandwana001/2769/force-version-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2769
@shobhitagarwal1612 PTAL?