Image Resizing #3162
Open
Image Resizing #3162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3162 +/- ##
============================================
- Coverage 69.05% 68.79% -0.27%
Complexity 1378 1378
============================================
Files 287 287
Lines 7146 7174 +28
Branches 719 724 +5
============================================
Hits 4935 4935
- Misses 1822 1850 +28
Partials 389 389
🚀 New features to boost your workflow:
|
shobhitagarwal1612
requested changes
Jun 9, 2025
app/src/main/java/org/groundplatform/android/ui/common/BindingAdapters.kt
Show resolved
Hide resolved
app/src/main/java/org/groundplatform/android/ui/common/BindingAdapters.kt
Show resolved
Hide resolved
gino-m
requested changes
Jun 13, 2025
| .transform(RotateUsingExif(uri, view.context)) | ||
| .into(view) | ||
| } catch (exception: OutOfMemoryError) { |
There was a problem hiding this comment.
We don't need a custom message here.
| override fun transform(source: Bitmap): Bitmap { | ||
| val orientation = getOrientationFromExif(uri) | ||
| val rotateDegrees = getRotationDegrees(orientation) | ||
| return rotateBitmap(source, rotateDegrees) | ||
|
|
||
| val resizedBitmap = resizeBitmapIfNeeded(source, maxWidth, maxHeight) |
There was a problem hiding this comment.
This single responsibility (see https://en.wikipedia.org/wiki/Single-responsibility_principle) of this transformation is to rotate the image. Having it also resize would be surprising. Instead, create a separate ResizeTransformation and chain the two to achieve the desired result.
gino-m
requested changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3161
@shobhitagarwal1612 PTAL?