Skip to content

Fix https://github.com/gptme/gptme-agent-template/issues/21 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

k127
Copy link
Contributor

@k127 k127 commented Jul 26, 2025

Fix #21


Important

Reorders operations in fork.sh to ensure the initial setup task is created after adding the gptme-contrib submodule.

  • Behavior:
    • Reorders operations in fork.sh to create the initial setup task after adding the gptme-contrib submodule.
    • Ensures initial-agent-setup.md is copied and edited in the correct context.
  • Misc:
    • No changes to functionality or additional features added.

This description was created by Ellipsis for 110917f. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 110917f in 27 seconds. Click for details.
  • Reviewed 25 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. fork.sh:117
  • Draft comment:
    Good fix: Running tasks.py inside a subshell with (cd "${TARGET_DIR}" && ...) ensures it runs in the correct working directory, consistent with other commands.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. fork.sh:117
  • Draft comment:
    Consider quoting the command substitution $(iso_datetime) to avoid potential word splitting.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_ubjGyXRHIk1O3bHw

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@ErikBjare
Copy link
Member

Thanks for the fix, beat you to it with 5b98a83 :)

@ErikBjare ErikBjare closed this Jul 26, 2025
@k127 k127 deleted the issue-21 branch July 28, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fork.sh: tasks.py (from gptme-contrib repo) called before that repo is cloned
2 participants