-
Notifications
You must be signed in to change notification settings - Fork 238
k6browser: too many time series recommendation #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
...rces/k6/next/using-k6-browser/recommended-practices/preventing-too-many-time-series-issue.md
Outdated
Show resolved
Hide resolved
...rces/k6/next/using-k6-browser/recommended-practices/preventing-too-many-time-series-issue.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments, but generally looks good! Thanks @inancgumus!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @inancgumus!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments here, thanks for creating this new page @inancgumus. 🙇
Two things outside of the comments:
- What do you think of adding a mention of this new page to page.on()?
- Could you please also add these changes to the v1 docs?
Also, please let me know if you'd like me to make any of the changes I suggested to the PR, I'm happy to do it as well. 🙇
docs/sources/k6/next/using-k6-browser/recommended-practices/_index.md
Outdated
Show resolved
Hide resolved
...rces/k6/next/using-k6-browser/recommended-practices/preventing-too-many-time-series-issue.md
Outdated
Show resolved
Hide resolved
...rces/k6/next/using-k6-browser/recommended-practices/preventing-too-many-time-series-issue.md
Outdated
Show resolved
Hide resolved
...rces/k6/next/using-k6-browser/recommended-practices/preventing-too-many-time-series-issue.md
Outdated
Show resolved
Hide resolved
Hi @heitortsergent,
Yes, that makes sense 👍
Done. I've also updated the versions between v0.55 - v1.
Yep, sure ❤️ That would be great 🙇 |
b26ca5c
to
5abc911
Compare
Co-authored-by: Heitor Tashiro Sergent <[email protected]> Co-authored-by: Joan López de la Franca Beltran <[email protected]>
5abc911
to
db7e2f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inancgumus I made the changes from my comment. Let me know if everything looks ok, it LGTM. 🙇
What?
Users may generate too many browser URLs and encounter too many time-series errors. We may support these users and provide a workaround for using
page.on('metric')
. However, it's a common problem for many browser tests. And it's not easy for users themselves to figure it out. Unlike HTTP URL grouping, there's no dedicated section in our docs that explains this problem and how to solve it.Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.docs/sources/k6/v{most_recent_release}
folder of the documentation.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)
NA