Skip to content

k6browser: too many time series recommendation #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

inancgumus
Copy link
Contributor

What?

Users may generate too many browser URLs and encounter too many time-series errors. We may support these users and provide a workaround for using page.on('metric'). However, it's a common problem for many browser tests. And it's not easy for users themselves to figure it out. Unlike HTTP URL grouping, there's no dedicated section in our docs that explains this problem and how to solve it.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

NA

@inancgumus inancgumus self-assigned this Jun 13, 2025
@inancgumus inancgumus requested review from heitortsergent and a team as code owners June 13, 2025 15:09
@inancgumus inancgumus added the Area: browser The browser module label Jun 13, 2025
@inancgumus inancgumus requested review from ankur22, codebien and mpandurovic and removed request for a team, ankur22 and codebien June 13, 2025 15:09
Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor comments, but generally looks good! Thanks @inancgumus!

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @inancgumus!

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few small comments here, thanks for creating this new page @inancgumus. 🙇

Two things outside of the comments:

  • What do you think of adding a mention of this new page to page.on()?
  • Could you please also add these changes to the v1 docs?

Also, please let me know if you'd like me to make any of the changes I suggested to the PR, I'm happy to do it as well. 🙇

@inancgumus
Copy link
Contributor Author

inancgumus commented Jun 17, 2025

Hi @heitortsergent,

Adding a mention of this new page to page.on()?

Yes, that makes sense 👍

Could you please also add these changes to the v1 docs?

Done. I've also updated the versions between v0.55 - v1.

let me know if you'd like me to make any of the changes

Yep, sure ❤️ That would be great 🙇

@inancgumus inancgumus force-pushed the k6browser/too-many-time-series branch from b26ca5c to 5abc911 Compare June 17, 2025 15:26
@inancgumus inancgumus force-pushed the k6browser/too-many-time-series branch from 5abc911 to db7e2f8 Compare June 17, 2025 15:27
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inancgumus I made the changes from my comment. Let me know if everything looks ok, it LGTM. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: browser The browser module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants