Chore: Update workflows and create-plugin update #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesoreyeram
previously approved these changes
Jun 11, 2025
zoltanbedi
requested changes
Jun 11, 2025
zoltanbedi
reviewed
Jun 11, 2025
zoltanbedi
reviewed
Jun 11, 2025
zoltanbedi
reviewed
Jun 11, 2025
zoltanbedi
reviewed
Jun 11, 2025
package.json
Outdated
| "react": "18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "tslib": "2.5.3" | ||
| }, | ||
| "resolutions": { | ||
| "dompurify": "3.2.4" | ||
| "dompurify": "3.2.6" | ||
| }, | ||
| "packageManager": "[email protected]" |
There was a problem hiding this comment.
Can you please use latest yarn instead? It should also make the resolution field not needed.
There was a problem hiding this comment.
also run yarn audit to see anything outstanding
zoltanbedi
reviewed
Jun 11, 2025
zoltanbedi
reviewed
Jun 11, 2025
zoltanbedi
reviewed
Jun 11, 2025
|
@zoltanbedi I think I addressed all your comments. Could you please check again? |
zoltanbedi
reviewed
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done?
npx @grafana/create-plugin@latest update