chore: simplify embedded frontend UI #4326

korniltsev · 2025-07-29T04:16:27Z

Remove a lot of unused UI code (authorization, api keys, adhoc, settings, tag explorer)
Remove some of UI (diff, compare), leave only single flame graph page. I assume not a lot of people use diff and compare , so I propose to sacrifice them.
Remove tests and test dependencies. I mostly propose to do this to have less dependencies and less "security" updates.
Drastically reduces the redux state, should simplify updates/migrations there in the future.

This draft is just an RFC - attempt to improve and simplify our maintenance of embedded frontend. Curious what others think of my assumptions 🧠 and sacrifices 🗡️

simonswine · 2025-07-29T08:46:59Z

Yes, I would support this effort!

…ibe-coding

korniltsev · 2025-07-29T09:18:12Z

This is how it would look

🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>

Reverts package.json, tsconfig.json, and yarn.lock to main branch state to resolve React component type errors. The removal of Jest dependencies caused yarn to resolve incompatible React type versions that broke JSX component compilation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Successfully removes all Jest-related dependencies while maintaining working typecheck: - Removed jest core package and all jest-* plugins (fetch-mock, environment-jsdom, css-modules-transform, canvas-mock, image-snapshot) - Removed all @testing-library packages (react, jest-dom, dom, user-event, cypress) - Removed jest-related type definitions (@types/jest, @types/jest-image-snapshot, @types/testing-library__jest-dom, @types/mocha) - Removed SWC Jest integration (@swc/jest) and TypeScript Jest (ts-jest) - Removed Cypress testing framework and related packages - Removed testing-related ESLint plugins (eslint-plugin-jest, eslint-plugin-cypress) - Removed canvas packages used by Jest (canvas, canvas-to-buffer) - Removed test scripts ("test": "jest", "cy": "cypress") - Updated tsconfig.json to remove @types/jest from types array 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

This restores all Jest testing dependencies and configuration from the main branch before systematic removal. Co-Authored-By: Claude <[email protected]>

SWC Jest transformer removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Testing Library for Cypress removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Testing Library DOM utilities removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Testing Library Jest DOM matchers removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Removed @testing-library/react, @testing-library/user-event, and @types/testing-library__jest-dom successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Removed jest, ts-jest, jest-environment-jsdom, canvas, and canvas-to-buffer successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Removed @types/jest from both package.json and tsconfig.json, plus jest-canvas-mock, jest-css-modules-transform, jest-fetch-mock, and jest-image-snapshot. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Removed final Jest and testing dependencies: - cypress, eslint-plugin-cypress, eslint-plugin-jest - @types/mocha - test and cy scripts from package.json All Jest dependencies successfully removed. Frontend build and typecheck pass completely. Co-Authored-By: Claude <[email protected]>

…ibe-coding

Copilot

Pull Request Overview

This pull request simplifies the embedded frontend UI by removing various features and dependencies. It eliminates unused UI sections including authorization, API keys, adhoc analysis, settings, tag explorer, diff/comparison views while retaining only the single flame graph page functionality. The changes also remove tests and test dependencies to reduce maintenance burden and security updates.

Removes authorization, API keys, adhoc, settings, and tag explorer functionality
Eliminates diff and comparison UI components, keeping only single flame graph view
Removes tests and test dependencies to reduce maintenance overhead

Reviewed Changes

Copilot reviewed 187 out of 211 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
public/app/services/apiKeys.ts	Removes API key management service functions
public/app/services/annotations.ts	Removes annotation service functionality
public/app/services/adhoc.ts	Removes adhoc profiling service and file upload utilities
public/app/redux/useReduxQuerySync.ts	Removes tracing and tag explorer state synchronization
public/app/redux/store.ts	Simplifies Redux store by removing unused reducers
public/app/redux/reducers/user.ts	Removes user management Redux state and actions
public/app/redux/reducers/ui.ts	Removes sidebar state management
public/app/redux/reducers/tracing.ts	Removes tracing view Redux state and thunks
public/app/redux/reducers/settings.ts	Removes settings page Redux state management
public/app/redux/reducers/serviceDiscovery.ts	Removes service discovery Redux state
public/app/redux/reducers/continuous/*.ts	Removes tag explorer, comparison, diff, and annotation functionality
public/app/redux/reducers/adhoc.ts	Removes adhoc profiling Redux state management
public/app/pages/urls.ts	Removes URL constants for removed pages
public/app/pages/tagExplorer/components/*.tsx	Removes tag explorer UI components
public/app/pages/routes.ts	Removes route constants for removed views
public/app/pages/exemplars/*.tsx	Removes exemplars view components
public/app/pages/adhoc/*.tsx	Removes adhoc profiling UI components
public/app/pages/*.tsx	Removes various page components and utilities

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T12:26:06Z

public/app/redux/reducers/continuous/state.ts

 type TimelineState =
  | { type: 'pristine'; timeline: Timeline }
  | { type: 'loading'; timeline: Timeline }
  | { type: 'reloading'; timeline: Timeline }
-  | { type: 'loaded'; timeline: Timeline; annotations: Annotation[] };
+  | { type: 'loaded'; timeline: Timeline };


[nitpick] The timeline state type definition has inconsistent structure. The 'loaded' type should maintain the same structure as the other states for consistency.

korniltsev added 10 commits July 19, 2025 14:27

remove annotations, adhoc, settings

d75e962

remove tag explorer

3dcd41f

remove diff and comparision

1e2fdb8

remove tracing

0fd1d19

remove apikeys

cdef0a4

remove users

a048d3c

remove collapsing

7eea74f

remove some more unused ui

b6d44db

remove og/webapp

36188fb

remove tests and test depdendencies

c4e71ca

Merge remote-tracking branch 'origin/main' into korniltsev/frontend-v…

4a59ab7

…ibe-coding

korniltsev marked this pull request as ready for review July 29, 2025 09:18

korniltsev requested a review from a team as a code owner July 29, 2025 09:18

korniltsev added 5 commits July 29, 2025 16:26

yarn run format:fix

dc2c7f0

yarn lint:fix

7fe4829

rm FileLists

f76166a

remove convertJaegerTraceToProfile

9e78da3

yarn type-check

abc72f9

korniltsev marked this pull request as draft July 29, 2025 09:38

korniltsev and others added 9 commits August 15, 2025 15:59

Format export statement in flamegraph index

71571ae

🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>

Restore Jest dependencies from main branch

d6cae73

This restores all Jest testing dependencies and configuration from the main branch before systematic removal. Co-Authored-By: Claude <[email protected]>

Remove @swc/jest dependency

98d61d6

SWC Jest transformer removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Remove @testing-library/cypress dependency

032e568

Testing Library for Cypress removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Remove @testing-library/dom dependency

be715f6

Testing Library DOM utilities removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Remove @testing-library/jest-dom dependency

30d9b05

Testing Library Jest DOM matchers removed successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Remove Testing Library React and user-event dependencies

c61d6f6

Removed @testing-library/react, @testing-library/user-event, and @types/testing-library__jest-dom successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

korniltsev and others added 3 commits August 15, 2025 18:17

Remove Jest core dependencies and canvas packages

b2fa5d8

Removed jest, ts-jest, jest-environment-jsdom, canvas, and canvas-to-buffer successfully. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

Remove Jest types and remaining Jest utilities

184cde9

Removed @types/jest from both package.json and tsconfig.json, plus jest-canvas-mock, jest-css-modules-transform, jest-fetch-mock, and jest-image-snapshot. Build and typecheck pass. Co-Authored-By: Claude <[email protected]>

korniltsev force-pushed the korniltsev/frontend-vibe-coding branch from 01aacf0 to fcee814 Compare August 15, 2025 12:18

Merge remote-tracking branch 'origin/main' into korniltsev/frontend-v…

b57a111

…ibe-coding

korniltsev marked this pull request as ready for review August 15, 2025 12:23

korniltsev requested a review from Copilot August 15, 2025 12:25

Copilot AI reviewed Aug 15, 2025

View reviewed changes

rm e2e

82b7239

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: simplify embedded frontend UI #4326

chore: simplify embedded frontend UI #4326

korniltsev commented Jul 29, 2025 •

edited

Loading

Uh oh!

simonswine commented Jul 29, 2025

Uh oh!

korniltsev commented Jul 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

Uh oh!

chore: simplify embedded frontend UI #4326

Are you sure you want to change the base?

chore: simplify embedded frontend UI #4326

Conversation

korniltsev commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonswine commented Jul 29, 2025

Uh oh!

korniltsev commented Jul 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

korniltsev commented Jul 29, 2025 •

edited

Loading