Use Default Newtonsoft serializer settings for deserializing WebsocketMessageWrapper
#661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ket message wrapper response Signed-off-by: Jedd Morgan <[email protected]>
|
@rose-a how important is it that the map converter is configured on the serialization settings. Tests appear to pass either way. |
|
@rose-a anything more you want me to do here? |
|
Hi, sorry for not picking this up already, I'm extremely low on spare time recently... I might find the time for this in August, feel free to ping me again if nothing happens 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #660