Skip to content

Introduce a NameResolver for Android's intent: URIs #12248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

jdcormie
Copy link
Member

@jdcormie jdcormie commented Jul 29, 2025

Let grpc-binder clients find on-device services by implicit Intent target URI, lifting the need to hard code a server's package name.

Android aspects of this code have already been reviewed internally. See http://cs/symbol:AndroidIntentNameResolver

Design at: go/grpc-binder-service-discovery

@jdcormie jdcormie requested a review from ejona86 July 29, 2025 08:29
@jdcormie
Copy link
Member Author

jdcormie commented Aug 1, 2025

@ejona86 Do you still want to take a look at this or should I proceed based on @kannanjgithub's approval?

@ejona86
Copy link
Member

ejona86 commented Aug 1, 2025

Let's give me the rest of today to take a look.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybeCreateAndDefaultRegister() is my biggest concern. The other things are smaller. The Status codes we do need to be careful about, though, but it is also an easy fix.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some comments from Friday that I didn't have an opportunity to finish. We can leave UNIMPLEMENTED for the moment; I've added a discussion topic for cross-language discussion. The exception just needs added context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants