-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Introduce a NameResolver for Android's intent:
URIs
#12248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ejona86 Do you still want to take a look at this or should I proceed based on @kannanjgithub's approval? |
Let's give me the rest of today to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybeCreateAndDefaultRegister() is my biggest concern. The other things are smaller. The Status codes we do need to be careful about, though, but it is also an easy fix.
binder/src/main/java/io/grpc/binder/internal/IntentNameResolverProvider.java
Outdated
Show resolved
Hide resolved
binder/src/main/java/io/grpc/binder/internal/IntentNameResolverProvider.java
Outdated
Show resolved
Hide resolved
binder/src/main/java/io/grpc/binder/internal/IntentNameResolver.java
Outdated
Show resolved
Hide resolved
binder/src/main/java/io/grpc/binder/internal/IntentNameResolver.java
Outdated
Show resolved
Hide resolved
Internally CL/789892493
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some comments from Friday that I didn't have an opportunity to finish. We can leave UNIMPLEMENTED for the moment; I've added a discussion topic for cross-language discussion. The exception just needs added context.
Let grpc-binder clients find on-device services by implicit Intent target URI, lifting the need to hard code a server's package name.
Android aspects of this code have already been reviewed internally. See http://cs/symbol:AndroidIntentNameResolver
Design at: go/grpc-binder-service-discovery