Skip to content

add new DPoPTokenSerializer class for [de]serializing DPoPToken #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snarfed
Copy link
Contributor

@snarfed snarfed commented Jul 9, 2025

for #122

@guillp one note here: this duplicates the existing code in AuthorizationRequestSerializer for [de]serializing DPoPKey. would you want a new DPoPKeySerializer class for that? I wasn't sure if you'd care more about the code duplication or the serializer class sprawl. I'm ok either way.

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.94%. Comparing base (7fa1c7e) to head (0ca1b1e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
requests_oauth2client/dpop.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #174      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           19       19              
  Lines         1934     1955      +21     
===========================================
+ Hits          1934     1954      +20     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snarfed
Copy link
Contributor Author

snarfed commented Jul 31, 2025

@guillp friendly ping? I'd love to get back to using requests_oauth2client from upstream here instead of my fork!...but I need this PR first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant