Do not hide diagnostics in RepositoryValidatingInterceptor
#7070
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
RepositoryValidatingInterceptor
outputs only the first issue, whether or not that is the issue that triggers the operation to fail validation. E.g. if the first issue isINFO
, the user will not be informed why the validation failed.This is a simple improvement that outputs diagnostics for all issues. This does change default behaviour, so we could feature-flag it.
Ideally, I think we'd:
SEVERITY: Diagnostics
But I am not certain whether this information is available from the
IBaseOperationOutcome
, because the code inOperationOutcomeUtil.getIssueStringPart
is quite reflexive :-)Tests
FhirContext
inhapi-fhir-base
, because it does not include any FHIR structure JARs.OperationOutcomeUtil
is covered by the test.