7152 - Add resource type to HFJ_RESOURCE_MODIFIED's PK to avoid conflicts #7154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Formatting check succeeded! |
tadgh
approved these changes
Jul 30, 2025
| type: fix | ||
| issue: 7152 | ||
| jira: SMILE-10226 | ||
| title: "Modified resources could potentially be removed from the subscription list of they shared ID and Version with |
There was a problem hiding this comment.
issue: rewrite this changelog. There's a typo in it, and it should be written from a user failure scenario point of view. Something like:
Previously, subscriptions could occasionally fail to be delivered if a resource had the same ID as a resource of another type, (e.g. `Patient/abc-123` and `Observation/abc-123`), as well as the same version number. This has been corrected, and now the resource type is part of the primary key, ensuring uniqueness during clearing of the table.
| { | ||
| version.onTable("HFJ_RESOURCE_MODIFIED").dropPrimaryKey("20250729.1"); | ||
| version.onTable("HFJ_RESOURCE_MODIFIED").addPrimaryKey("20250729.2", "RES_ID", "RES_VER", "RESOURCE_TYPE"); | ||
| } |
There was a problem hiding this comment.
question: is this not making it into 8.4.0? Check with the support person/the ticket to ensure that this is known to them, and it isn't expected for 8.4.0
…hare external ID and version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.