Skip to content

Remove the disabled state from the submit button in forms #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

hiderr
Copy link
Collaborator

@hiderr hiderr commented Apr 16, 2025

Form Validation Improvement PR

Overview

This PR enhances form validation across the application by removing unnecessary validation checks that block form submissions, improving user experience by allowing users to attempt submissions even when validation errors are present.

Key Changes

Form Button Submission Logic

  • Removed isValid checks from form submission buttons in multiple components, the submit button should not be disabled from pressing
  • Server-side validation errors will still be properly displayed
  • Form fields will still show individual validation errors to guide users

Error Handling Improvements

  • Added proper Alert components to display server errors in authentication forms

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ 3em
❌ hiderr
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 35a3ba2
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/6810817a7b1a640008011ccc
😎 Deploy Preview https://deploy-preview-1484--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 35a3ba2
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/68108178a407c90008752923
😎 Deploy Preview https://deploy-preview-1484--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiderr hiderr force-pushed the fix-forms-button-submit-state branch from fe1f8c5 to bbb379d Compare April 17, 2025 08:59
@hiderr hiderr force-pushed the fix-forms-button-submit-state branch from bbb379d to 918d0a4 Compare April 18, 2025 15:27
@3em 3em requested a review from knagurski April 21, 2025 13:04
@3em 3em force-pushed the fix-forms-button-submit-state branch from 918d0a4 to 8ce58ed Compare April 28, 2025 11:54
@3em 3em changed the title remove disable in dialogs Remove the disabled state from the submit button in forms Apr 28, 2025
Copy link
Collaborator

@knagurski knagurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suuuuuuuper minor thing that's totally not a blocker.

@3em 3em force-pushed the fix-forms-button-submit-state branch from f2f0e73 to e6ddf45 Compare April 29, 2025 07:28
@3em 3em merged commit 27fa9f6 into main Apr 29, 2025
20 checks passed
@3em 3em deleted the fix-forms-button-submit-state branch April 29, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants