-
Notifications
You must be signed in to change notification settings - Fork 8
Remove the disabled state from the submit button in forms #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fe1f8c5
to
bbb379d
Compare
packages/ui/src/components/commit-suggestions-dialog/commit-suggestions-dialog.tsx
Outdated
Show resolved
Hide resolved
bbb379d
to
918d0a4
Compare
918d0a4
to
8ce58ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suuuuuuuper minor thing that's totally not a blocker.
packages/ui/src/components/commit-suggestions-dialog/commit-suggestions-dialog.tsx
Outdated
Show resolved
Hide resolved
f2f0e73
to
e6ddf45
Compare
Form Validation Improvement PR
Overview
This PR enhances form validation across the application by removing unnecessary validation checks that block form submissions, improving user experience by allowing users to attempt submissions even when validation errors are present.
Key Changes
Form Button Submission Logic
isValid
checks from form submission buttons in multiple components, the submit button should not be disabled from pressingError Handling Improvements