-
Notifications
You must be signed in to change notification settings - Fork 327
docs: update resource entry comments for CPU limits and production recs #4518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey @natemollica-nm . Thanks for the PR I can see a couple of acceptance tests failing. Since you've added/modified some tests, they might be related to it. Can you look into it and get it to a passing state? |
Yes! I'll dig into it more this week 😅 |
d2d1792
to
33bcd6e
Compare
I'm able to pass all the failing acceptance tests from my local branch for the
I haven't touched any of the acceptance test framework for this PR. Only Helm chart unit tests for the Is this test flaky at all in your experience? Is there anything I can do on my end to ensure this test passes? |
…rminating-gateways
…ent resource deployment settings
33bcd6e
to
cc635f5
Compare
Changes proposed in this PR
null
in production for service-mesh–related components (e.g., connectInject, meshGateway, terminatingGateway, API Gateway, etc.).How I've tested this PR
null
for service mesh components.How I expect reviewers to test this PR
null
CPU limit changes for mesh components.helm template
or local deployment to see the changes in resource definitions, ensuring the new CPU limit settings appear as commented.null
CPU limits for mesh components are understandable.Checklist
charts/consul/test/unit
tests:connect-inject-deployment.bats
ingress-gateways-deployment.bats
mesh-gateway-deployment.bats
server-statefulset.bats
terminating-gateways-deployment.bats