Skip to content

Fixing multiple flaky test failures due to timeout, version updates, script changes #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 28, 2025

Conversation

pajay-rao
Copy link
Collaborator

@pajay-rao pajay-rao commented May 15, 2025

This PR fixes multiple small issues on GitHub workflows.
Tests are flaky due to multiple issues including test timeouts, terraform version updates and terraform script updates.

This PR reduces the flaky failure of the tests but still there are issues which surface randomly.

Executions:
https://github.com/hashicorp/consul-k8s-workflows/actions/runs/15069649253/attempts/1

Changes proposed in this PR

How I've tested this PR

How I expect reviewers to test this PR

Checklist

Copy link

hashicorp-cla-app bot commented May 15, 2025

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • pajay-rao
  • P Ajay Rao

P Ajay Rao seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@pajay-rao pajay-rao changed the title Increasing retry count from 120 to 200 for TestAPIGateway_Tenancy Fixing multiple flaky test failures due to timeout, version updates, script changes May 20, 2025
@pajay-rao pajay-rao marked this pull request as ready for review May 20, 2025 05:59
@pajay-rao pajay-rao requested a review from a team as a code owner May 20, 2025 05:59
sreeram77
sreeram77 previously approved these changes May 20, 2025
@pajay-rao pajay-rao enabled auto-merge (squash) May 21, 2025 08:26
Copy link
Contributor

@anandmukul93 anandmukul93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at the version bumps for eks and is the time for retries going to be enough ?

@pajay-rao pajay-rao added pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry labels May 23, 2025
@pajay-rao pajay-rao requested review from anandmukul93, sreeram77 and a team May 26, 2025 06:07
Copy link
Contributor

@anandmukul93 anandmukul93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the pr cloud acceptance workflow already fires the acceptance tests on consul-k8s-workflows via some test workflow. This will be redundant and wont be required.

@pajay-rao pajay-rao requested a review from anandmukul93 May 26, 2025 14:12
@pajay-rao pajay-rao force-pushed the pajay.rao/flaky-test-fix branch from 76b16ed to 312c662 Compare May 28, 2025 09:03
@pajay-rao pajay-rao changed the base branch from main to pajay.rao/commit-test May 28, 2025 09:06
@pajay-rao pajay-rao merged commit 588550c into pajay.rao/commit-test May 28, 2025
21 of 28 checks passed
@pajay-rao pajay-rao deleted the pajay.rao/flaky-test-fix branch May 28, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants