-
Notifications
You must be signed in to change notification settings - Fork 327
Fixing multiple flaky test failures due to timeout, version updates, script changes #4576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
P Ajay Rao seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look at the version bumps for eks and is the time for retries going to be enough ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the pr cloud acceptance workflow already fires the acceptance tests on consul-k8s-workflows via some test workflow. This will be redundant and wont be required.
76b16ed
to
312c662
Compare
This PR fixes multiple small issues on GitHub workflows.
Tests are flaky due to multiple issues including test timeouts, terraform version updates and terraform script updates.
This PR reduces the flaky failure of the tests but still there are issues which surface randomly.
Executions:
https://github.com/hashicorp/consul-k8s-workflows/actions/runs/15069649253/attempts/1
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist