-
Notifications
You must be signed in to change notification settings - Fork 9.6k
aws_glue_catalog_database: when create_table_default_permission is present, but empty, create default LF permissions, not IAM_ALLOWED_PRINCIPALS (legacy/hybrid) permissions #43226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
aws_glue_catalog_database: when create_table_default_permission is present, but empty, create default LF permissions, not IAM_ALLOWED_PRINCIPALS (legacy/hybrid) permissions #43226
Conversation
…"-only permissions fixes hashicorp#27295
…"-only permissions fixes hashicorp#27295 - cleaner version
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Refactored to better integrate @jar-b's comments here. Tests results
|
Description
As described in #27295, this resource would always create a glue database with IAM_ALLOWED_PRINCIPALS group in the permissions (i.e. IAM-only or Hybrid permissions, not Lake Formation permissions).
This PR makes it possible to create a database with Lake Formation permissions.
Relations
Closes #27295
References
https://docs.aws.amazon.com/glue/latest/webapi/API_DatabaseInput.html#Glue-Type-DatabaseInput-CreateTableDefaultPermissions
Output from Acceptance Testing