Skip to content

[New Resource] aws_sagemaker_cluster for Sagemaker Hyperpod Cluster #43321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

talaha3
Copy link

@talaha3 talaha3 commented Jul 9, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR introduces a new resource to support the AWS Sagemaker Hyperpod Cluster service. It contains the documentation, the implementation and working acceptance tests for the resource.

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerCluster PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerCluster'  -timeout 360m -vet=off
2025/07/17 16:28:24 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 16:28:24 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMakerCluster_basic
=== PAUSE TestAccSageMakerCluster_basic
=== RUN   TestAccSageMakerCluster_disappears
=== PAUSE TestAccSageMakerCluster_disappears
=== RUN   TestAccSageMakerCluster_tags
=== PAUSE TestAccSageMakerCluster_tags
=== RUN   TestAccSageMakerCluster_updateInstanceGroups
=== PAUSE TestAccSageMakerCluster_updateInstanceGroups
=== RUN   TestAccSageMakerCluster_forceReplacement
=== PAUSE TestAccSageMakerCluster_forceReplacement
=== CONT  TestAccSageMakerCluster_basic
=== CONT  TestAccSageMakerCluster_updateInstanceGroups
=== CONT  TestAccSageMakerCluster_tags
=== CONT  TestAccSageMakerCluster_disappears
=== CONT  TestAccSageMakerCluster_forceReplacement
--- PASS: TestAccSageMakerCluster_basic (360.83s)
--- PASS: TestAccSageMakerCluster_disappears (410.96s)
--- PASS: TestAccSageMakerCluster_tags (471.06s)
--- PASS: TestAccSageMakerCluster_updateInstanceGroups (574.54s)
--- PASS: TestAccSageMakerCluster_forceReplacement (712.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  717.391s
...

Copy link
Contributor

github-actions bot commented Jul 9, 2025

⚠️ Our automation has detected the following potential issues with your pull request


❌ Maintainer Edit Permissions (Click to expand)

At times, our maintainers need to make direct edits to pull requests in order to prepare it to be merged. At the time of opening this pull request, your settings do not allow maintainers to make such edits. If possible, update your settings as described in the following document. If your fork is owned by an organization that limits your ability to make this change, please let us know.

Please see the GitHub documentation on allowing changes to a pull request branch created from a fork for additional details.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 9, 2025
@talaha3 talaha3 changed the title [WIP][New Resource] aws_sagemaker_cluster for Sagemaker Hyperpod Cluster [New Resource] aws_sagemaker_cluster for Sagemaker Hyperpod Cluster Jul 17, 2025
@talaha3 talaha3 marked this pull request as ready for review July 17, 2025 15:43
@talaha3 talaha3 requested a review from a team as a code owner July 17, 2025 15:43
Comment on lines +4 to +7

```release-note:new-guide
AWS: aws_sagemaker_cluster
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick initial review during triage: we won't need this new-guide entry

Suggested change
```release-note:new-guide
AWS: aws_sagemaker_cluster
```

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants