Skip to content

[New Resource] aws_bedrockagent_agent_prepare #43354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[New Resource] aws_bedrockagent_agent_prepare #43354

wants to merge 7 commits into from

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jul 11, 2025 •
edited by ewbankkit
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

New Resource aws_bedrockagent_agent_prepare to allow direct preparing of an agent to give finer control where there are multiple resources and/or collaborators being associated with the agent.

Relations

Closes #43059.
Closes #43129.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccBedrockAgentAgentPrepare_' PKG=bedrockagent ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/bedrockagent/... -v -count 1 -parallel 4  -run=TestAccBedrockAgentAgentPrepare_ -timeout 360m -vet=off
2025/07/11 10:46:44 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/11 10:46:44 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBedrockAgentAgentPrepare_basic
=== PAUSE TestAccBedrockAgentAgentPrepare_basic
=== CONT  TestAccBedrockAgentAgentPrepare_basic
--- PASS: TestAccBedrockAgentAgentPrepare_basic (28.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       33.265s

@github-actions GitHub Actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Jul 11, 2025
@drewtul drewtul marked this pull request as ready for review July 11, 2025 11:56
@drewtul drewtul requested a review from a team as a code owner July 11, 2025 11:56
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 11, 2025
milowg
milowg reviewed Jul 15, 2025
View reviewed changes
internal/service/bedrockagent/prepare_agent.go
resp.Diagnostics.Append(resp.State.Set(ctx, &state)...)
}

func (r *resourceAgentPrepare) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this prepare the agent on subsequent applies if it has changed?

The agent resource currently does this: https://github.com/hashicorp/terraform-provider-aws/blame/main/internal/service/bedrockagent/agent.go#L352

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't any attributes on this resource you can use to trigger an update, it would need to use lifecycle arguments to trigger a replacement when the agent or any resources associated with the agent are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milowg milowg milowg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't Prepare a SUPERVISOR Bedrock Agent when it is created
3 participants
@drewtul @milowg @ewbankkit