Skip to content

Technical debt: Use internal/retry for tfresource.RetryWhenNewResourceNotFound #43412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Technical debt: Use internal/retry for tfresource.RetryWhenNewResourceNotFound #43412

wants to merge 43 commits into from
+1,167 −1,204

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 16, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Use the new primitives in internal/retry (as a replacement for the SDKv2 helper/retry package) for tfresource.RetryUntilNewResourceNotFound.
Also converts tfresource.RetryUntilNewResourceNotFound to a generic function.

Relations

Relates #42554.
Relates #43267.
Relates #43341.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAppAutoScalingTarget_basic' PKG=appautoscaling
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/appautoscaling/... -v -count 1 -parallel 20  -run=TestAccAppAutoScalingTarget_basic -timeout 360m -vet=off
2025/07/16 15:38:40 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 15:38:40 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAppAutoScalingTarget_basic
=== PAUSE TestAccAppAutoScalingTarget_basic
=== CONT  TestAccAppAutoScalingTarget_basic
--- PASS: TestAccAppAutoScalingTarget_basic (76.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	81.251s
% make testacc TESTARGS='-run=TestAccCloudTrail_serial/Trail/basic' PKG=cloudtrail
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20  -run=TestAccCloudTrail_serial/Trail/basic -timeout 360m -vet=off
2025/07/16 15:41:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 15:41:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCloudTrail_serial
=== PAUSE TestAccCloudTrail_serial
=== CONT  TestAccCloudTrail_serial
=== RUN   TestAccCloudTrail_serial/Trail
=== RUN   TestAccCloudTrail_serial/Trail/basic
--- PASS: TestAccCloudTrail_serial (36.44s)
    --- PASS: TestAccCloudTrail_serial/Trail (36.44s)
        --- PASS: TestAccCloudTrail_serial/Trail/basic (36.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	41.274s
% make testacc TESTARGS='-run=TestAccIAM.+_basic' PKG=iam ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/iam/... -v -count 1 -parallel 2  -run=TestAccIAM.+_basic -timeout 360m -vet=off
2025/07/16 15:47:48 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 15:47:48 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccIAMAccessKey_basic
=== PAUSE TestAccIAMAccessKey_basic
=== RUN   TestAccIAMAccessKeysDataSource_basic
=== PAUSE TestAccIAMAccessKeysDataSource_basic
=== RUN   TestAccIAMGroupDataSource_basic
=== PAUSE TestAccIAMGroupDataSource_basic
=== RUN   TestAccIAMGroupMembership_basic
=== PAUSE TestAccIAMGroupMembership_basic
=== RUN   TestAccIAMGroupPoliciesExclusive_basic
=== PAUSE TestAccIAMGroupPoliciesExclusive_basic
=== RUN   TestAccIAMGroupPolicyAttachment_basic
=== PAUSE TestAccIAMGroupPolicyAttachment_basic
=== RUN   TestAccIAMGroupPolicyAttachmentsExclusive_basic
=== PAUSE TestAccIAMGroupPolicyAttachmentsExclusive_basic
=== RUN   TestAccIAMGroupPolicy_basic
=== PAUSE TestAccIAMGroupPolicy_basic
=== RUN   TestAccIAMGroup_basic
=== PAUSE TestAccIAMGroup_basic
=== RUN   TestAccIAMInstanceProfileDataSource_basic
=== PAUSE TestAccIAMInstanceProfileDataSource_basic
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMInstanceProfilesDataSource_basic
=== PAUSE TestAccIAMInstanceProfilesDataSource_basic
=== RUN   TestAccIAMOpenidConnectProviderDataSource_basic
=== PAUSE TestAccIAMOpenidConnectProviderDataSource_basic
=== RUN   TestAccIAMOpenIDConnectProvider_basic
=== PAUSE TestAccIAMOpenIDConnectProvider_basic
=== RUN   TestAccIAMPolicyAttachment_basic
=== PAUSE TestAccIAMPolicyAttachment_basic
=== RUN   TestAccIAMPolicyDocumentDataSource_basic
=== PAUSE TestAccIAMPolicyDocumentDataSource_basic
=== RUN   TestAccIAMPolicy_basic
=== PAUSE TestAccIAMPolicy_basic
=== RUN   TestAccIAMPrincipalPolicySimulationDataSource_basic
=== PAUSE TestAccIAMPrincipalPolicySimulationDataSource_basic
=== RUN   TestAccIAMRoleDataSource_basic
=== PAUSE TestAccIAMRoleDataSource_basic
=== RUN   TestAccIAMRolePoliciesExclusive_basic
=== PAUSE TestAccIAMRolePoliciesExclusive_basic
=== RUN   TestAccIAMRolePolicyAttachment_basic
=== PAUSE TestAccIAMRolePolicyAttachment_basic
=== RUN   TestAccIAMRolePolicyAttachmentsExclusive_basic
=== PAUSE TestAccIAMRolePolicyAttachmentsExclusive_basic
=== RUN   TestAccIAMRolePolicy_basic
=== PAUSE TestAccIAMRolePolicy_basic
=== RUN   TestAccIAMRole_basic
=== PAUSE TestAccIAMRole_basic
=== RUN   TestAccIAMRole_InlinePolicy_basic
=== PAUSE TestAccIAMRole_InlinePolicy_basic
=== RUN   TestAccIAMRole_ManagedPolicy_basic
=== PAUSE TestAccIAMRole_ManagedPolicy_basic
=== RUN   TestAccIAMRolesDataSource_basic
=== PAUSE TestAccIAMRolesDataSource_basic
=== RUN   TestAccIAMSAMLProviderDataSource_basic
=== PAUSE TestAccIAMSAMLProviderDataSource_basic
=== RUN   TestAccIAMSAMLProvider_basic
=== PAUSE TestAccIAMSAMLProvider_basic
=== RUN   TestAccIAMSecurityTokenServicePreferences_basic
=== PAUSE TestAccIAMSecurityTokenServicePreferences_basic
=== RUN   TestAccIAMServerCertificateDataSource_basic
=== PAUSE TestAccIAMServerCertificateDataSource_basic
=== RUN   TestAccIAMServerCertificate_basic
=== PAUSE TestAccIAMServerCertificate_basic
=== RUN   TestAccIAMServiceLinkedRole_basic
=== PAUSE TestAccIAMServiceLinkedRole_basic
=== RUN   TestAccIAMServiceSpecificCredential_basic
=== PAUSE TestAccIAMServiceSpecificCredential_basic
=== RUN   TestAccIAMSessionContextDataSource_basic
=== PAUSE TestAccIAMSessionContextDataSource_basic
=== RUN   TestAccIAMSigningCertificate_basic
=== PAUSE TestAccIAMSigningCertificate_basic
=== RUN   TestAccIAMUserDataSource_basic
=== PAUSE TestAccIAMUserDataSource_basic
=== RUN   TestAccIAMUserGroupMembership_basic
=== PAUSE TestAccIAMUserGroupMembership_basic
=== RUN   TestAccIAMUserLoginProfile_basic
=== PAUSE TestAccIAMUserLoginProfile_basic
=== RUN   TestAccIAMUserPoliciesExclusive_basic
=== PAUSE TestAccIAMUserPoliciesExclusive_basic
=== RUN   TestAccIAMUserPolicyAttachment_basic
=== PAUSE TestAccIAMUserPolicyAttachment_basic
=== RUN   TestAccIAMUserPolicyAttachmentsExclusive_basic
=== PAUSE TestAccIAMUserPolicyAttachmentsExclusive_basic
=== RUN   TestAccIAMUserPolicy_basic
=== PAUSE TestAccIAMUserPolicy_basic
=== RUN   TestAccIAMUserSSHKeyDataSource_basic
=== PAUSE TestAccIAMUserSSHKeyDataSource_basic
=== RUN   TestAccIAMUserSSHKey_basic
=== PAUSE TestAccIAMUserSSHKey_basic
=== RUN   TestAccIAMUser_basic
=== PAUSE TestAccIAMUser_basic
=== RUN   TestAccIAMVirtualMFADevice_basic
=== PAUSE TestAccIAMVirtualMFADevice_basic
=== CONT  TestAccIAMAccessKey_basic
=== CONT  TestAccIAMUserSSHKeyDataSource_basic
--- PASS: TestAccIAMUserSSHKeyDataSource_basic (10.48s)
=== CONT  TestAccIAMUser_basic
--- PASS: TestAccIAMAccessKey_basic (12.24s)
=== CONT  TestAccIAMVirtualMFADevice_basic
--- PASS: TestAccIAMVirtualMFADevice_basic (11.62s)
=== CONT  TestAccIAMRolePolicy_basic
--- PASS: TestAccIAMRolePolicy_basic (12.03s)
=== CONT  TestAccIAMUserPolicy_basic
--- PASS: TestAccIAMUserPolicy_basic (19.45s)
=== CONT  TestAccIAMUserPolicyAttachmentsExclusive_basic
--- PASS: TestAccIAMUser_basic (48.21s)
=== CONT  TestAccIAMUserPolicyAttachment_basic
--- PASS: TestAccIAMUserPolicyAttachmentsExclusive_basic (12.25s)
=== CONT  TestAccIAMUserPoliciesExclusive_basic
--- PASS: TestAccIAMUserPolicyAttachment_basic (19.52s)
=== CONT  TestAccIAMUserLoginProfile_basic
--- PASS: TestAccIAMUserPoliciesExclusive_basic (11.94s)
=== CONT  TestAccIAMUserGroupMembership_basic
--- PASS: TestAccIAMUserLoginProfile_basic (20.83s)
=== CONT  TestAccIAMUserDataSource_basic
--- PASS: TestAccIAMUserDataSource_basic (9.24s)
=== CONT  TestAccIAMSigningCertificate_basic
--- PASS: TestAccIAMSigningCertificate_basic (11.84s)
=== CONT  TestAccIAMSessionContextDataSource_basic
--- PASS: TestAccIAMUserGroupMembership_basic (46.54s)
=== CONT  TestAccIAMServiceSpecificCredential_basic
--- PASS: TestAccIAMSessionContextDataSource_basic (9.60s)
=== CONT  TestAccIAMServiceLinkedRole_basic
--- PASS: TestAccIAMServiceSpecificCredential_basic (11.63s)
=== CONT  TestAccIAMServerCertificate_basic
--- PASS: TestAccIAMServiceLinkedRole_basic (21.54s)
=== CONT  TestAccIAMServerCertificateDataSource_basic
--- PASS: TestAccIAMServerCertificate_basic (18.39s)
=== CONT  TestAccIAMSecurityTokenServicePreferences_basic
--- PASS: TestAccIAMServerCertificateDataSource_basic (9.82s)
=== CONT  TestAccIAMSAMLProvider_basic
--- PASS: TestAccIAMSecurityTokenServicePreferences_basic (8.73s)
=== CONT  TestAccIAMSAMLProviderDataSource_basic
--- PASS: TestAccIAMSAMLProviderDataSource_basic (9.40s)
=== CONT  TestAccIAMInstanceProfilesDataSource_basic
--- PASS: TestAccIAMSAMLProvider_basic (18.56s)
=== CONT  TestAccIAMRolesDataSource_basic
--- PASS: TestAccIAMRolesDataSource_basic (8.13s)
=== CONT  TestAccIAMRolePolicyAttachmentsExclusive_basic
--- PASS: TestAccIAMInstanceProfilesDataSource_basic (15.34s)
=== CONT  TestAccIAMRole_ManagedPolicy_basic
--- PASS: TestAccIAMRolePolicyAttachmentsExclusive_basic (12.39s)
=== CONT  TestAccIAMRolePolicyAttachment_basic
--- PASS: TestAccIAMRole_ManagedPolicy_basic (27.88s)
=== CONT  TestAccIAMRole_InlinePolicy_basic
--- PASS: TestAccIAMRolePolicyAttachment_basic (19.66s)
=== CONT  TestAccIAMRolePoliciesExclusive_basic
--- PASS: TestAccIAMRolePoliciesExclusive_basic (12.21s)
=== CONT  TestAccIAMRole_basic
--- PASS: TestAccIAMRole_basic (11.66s)
=== CONT  TestAccIAMRoleDataSource_basic
--- PASS: TestAccIAMRole_InlinePolicy_basic (26.89s)
=== CONT  TestAccIAMPolicyDocumentDataSource_basic
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (7.52s)
=== CONT  TestAccIAMPolicyAttachment_basic
--- PASS: TestAccIAMRoleDataSource_basic (9.60s)
=== CONT  TestAccIAMPrincipalPolicySimulationDataSource_basic
--- PASS: TestAccIAMPrincipalPolicySimulationDataSource_basic (13.55s)
=== CONT  TestAccIAMOpenIDConnectProvider_basic
--- PASS: TestAccIAMPolicyAttachment_basic (17.86s)
=== CONT  TestAccIAMPolicy_basic
--- PASS: TestAccIAMPolicy_basic (11.72s)
=== CONT  TestAccIAMOpenidConnectProviderDataSource_basic
--- PASS: TestAccIAMOpenIDConnectProvider_basic (19.83s)
=== CONT  TestAccIAMUserSSHKey_basic
--- PASS: TestAccIAMOpenidConnectProviderDataSource_basic (9.57s)
=== CONT  TestAccIAMGroupPolicyAttachmentsExclusive_basic
--- PASS: TestAccIAMUserSSHKey_basic (11.78s)
=== CONT  TestAccIAMInstanceProfile_basic
--- PASS: TestAccIAMGroupPolicyAttachmentsExclusive_basic (12.20s)
=== CONT  TestAccIAMGroup_basic
--- PASS: TestAccIAMGroup_basic (11.46s)
=== CONT  TestAccIAMGroupPolicy_basic
--- PASS: TestAccIAMInstanceProfile_basic (17.55s)
=== CONT  TestAccIAMInstanceProfileDataSource_basic
--- PASS: TestAccIAMGroupPolicy_basic (11.60s)
=== CONT  TestAccIAMGroupPolicyAttachment_basic
--- PASS: TestAccIAMInstanceProfileDataSource_basic (15.47s)
=== CONT  TestAccIAMGroupMembership_basic
--- PASS: TestAccIAMGroupPolicyAttachment_basic (18.80s)
=== CONT  TestAccIAMGroupPoliciesExclusive_basic
--- PASS: TestAccIAMGroupMembership_basic (23.56s)
=== CONT  TestAccIAMGroupDataSource_basic
--- PASS: TestAccIAMGroupPoliciesExclusive_basic (11.84s)
=== CONT  TestAccIAMAccessKeysDataSource_basic
--- PASS: TestAccIAMGroupDataSource_basic (8.90s)
--- PASS: TestAccIAMAccessKeysDataSource_basic (9.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	371.786s
% make testacc TESTARGS='-run=TestAccSiteVPNGateway_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccSiteVPNGateway_basic -timeout 360m -vet=off
2025/07/16 15:58:24 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 15:58:24 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSiteVPNGateway_basic
=== PAUSE TestAccSiteVPNGateway_basic
=== CONT  TestAccSiteVPNGateway_basic
--- PASS: TestAccSiteVPNGateway_basic (145.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	150.685s
% make testacc TESTARGS='-run=TestAccKMSKey_basic' PKG=kms
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSKey_basic -timeout 360m -vet=off
2025/07/16 16:02:55 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 16:02:55 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKMSKey_basic
=== PAUSE TestAccKMSKey_basic
=== CONT  TestAccKMSKey_basic
--- PASS: TestAccKMSKey_basic (39.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	44.219s
% make testacc TESTARGS='-run=TestAccSNSTopicSubscription_basic' PKG=sns
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/sns/... -v -count 1 -parallel 20  -run=TestAccSNSTopicSubscription_basic -timeout 360m -vet=off
2025/07/16 16:04:43 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 16:04:43 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSNSTopicSubscription_basic
=== PAUSE TestAccSNSTopicSubscription_basic
=== CONT  TestAccSNSTopicSubscription_basic
--- PASS: TestAccSNSTopicSubscription_basic (43.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	48.269s
% make testacc TESTARGS='-run=TestAccVPC_basic' PKG=ec2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_basic -timeout 360m -vet=off
2025/07/16 16:43:22 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 16:43:22 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_basic (17.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	22.542s
% make testacc TESTARGS='-run=TestAccVPCSecurityGroup_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCSecurityGroup_basic -timeout 360m -vet=off
2025/07/17 09:45:54 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 09:45:54 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCSecurityGroup_basic
=== PAUSE TestAccVPCSecurityGroup_basic
=== CONT  TestAccVPCSecurityGroup_basic
--- PASS: TestAccVPCSecurityGroup_basic (21.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	27.044s
% make testacc TESTARGS='-run=TestAccVPCInternetGateway_basic\|TestAccVPCNetworkInterface_basic\|TestAccVPCRouteTable_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCInternetGateway_basic\|TestAccVPCNetworkInterface_basic\|TestAccVPCRouteTable_basic -timeout 360m -vet=off
2025/07/17 10:38:40 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 10:38:40 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCInternetGateway_basic
=== PAUSE TestAccVPCInternetGateway_basic
=== RUN   TestAccVPCNetworkInterface_basic
=== PAUSE TestAccVPCNetworkInterface_basic
=== RUN   TestAccVPCRouteTable_basic
=== PAUSE TestAccVPCRouteTable_basic
=== CONT  TestAccVPCInternetGateway_basic
=== CONT  TestAccVPCRouteTable_basic
=== CONT  TestAccVPCNetworkInterface_basic
--- PASS: TestAccVPCInternetGateway_basic (14.90s)
--- PASS: TestAccVPCRouteTable_basic (20.36s)
--- PASS: TestAccVPCNetworkInterface_basic (34.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	39.107s
% make testacc TESTARGS='-run=TestAccVPCFlowLog_basic\|TestAccVPCNetworkACL_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCFlowLog_basic\|TestAccVPCNetworkACL_basic -timeout 360m -vet=off
2025/07/17 10:54:52 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 10:54:52 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCFlowLog_basic
=== PAUSE TestAccVPCFlowLog_basic
=== RUN   TestAccVPCNetworkACL_basic
=== PAUSE TestAccVPCNetworkACL_basic
=== CONT  TestAccVPCFlowLog_basic
=== CONT  TestAccVPCNetworkACL_basic
--- PASS: TestAccVPCNetworkACL_basic (18.49s)
--- PASS: TestAccVPCFlowLog_basic (20.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	25.134s
% make testacc TESTARGS='-run=TestAccVPCEndpointService_basic\|TestAccVPCEndpointServiceDataSource_ServiceType_gateway\|TestAccVPCDHCPOptions_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCEndpointService_basic\|TestAccVPCEndpointServiceDataSource_ServiceType_gateway\|TestAccVPCDHCPOptions_basic -timeout 360m -vet=off
2025/07/17 11:31:26 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 11:31:26 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccVPCDHCPOptions_basic
=== PAUSE TestAccVPCDHCPOptions_basic
=== RUN   TestAccVPCEndpointServiceDataSource_ServiceType_gateway
=== PAUSE TestAccVPCEndpointServiceDataSource_ServiceType_gateway
=== RUN   TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== CONT  TestAccVPCDHCPOptions_basic
=== CONT  TestAccVPCEndpointService_basic
=== CONT  TestAccVPCEndpointServiceDataSource_ServiceType_gateway
--- PASS: TestAccVPCEndpointServiceDataSource_ServiceType_gateway (10.62s)
--- PASS: TestAccVPCDHCPOptions_basic (15.06s)
--- PASS: TestAccVPCEndpointService_basic (235.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	240.458s
% make testacc TESTARGS='-run=TestAccEC2AMI_basic\|TestAccEC2Instance_basic\|TestAccEC2KeyPair_basic\|TestAccEC2LaunchTemplate_basic\|TestAccEC2EBSSnapshotImport_basic\|TestAccEC2PlacementGroup_basic' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2AMI_basic\|TestAccEC2Instance_basic\|TestAccEC2KeyPair_basic\|TestAccEC2LaunchTemplate_basic\|TestAccEC2EBSSnapshotImport_basic\|TestAccEC2PlacementGroup_basic -timeout 360m -vet=off
2025/07/17 15:38:23 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:38:23 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2EBSSnapshotImport_basic
=== PAUSE TestAccEC2EBSSnapshotImport_basic
=== RUN   TestAccEC2AMI_basic
=== PAUSE TestAccEC2AMI_basic
=== RUN   TestAccEC2Instance_basic
=== PAUSE TestAccEC2Instance_basic
=== RUN   TestAccEC2Instance_basicWithSpot
=== PAUSE TestAccEC2Instance_basicWithSpot
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== RUN   TestAccEC2LaunchTemplate_basic
=== PAUSE TestAccEC2LaunchTemplate_basic
=== RUN   TestAccEC2PlacementGroup_basic
=== PAUSE TestAccEC2PlacementGroup_basic
=== CONT  TestAccEC2EBSSnapshotImport_basic
=== CONT  TestAccEC2KeyPair_basic
=== CONT  TestAccEC2Instance_basic
=== CONT  TestAccEC2LaunchTemplate_basic
=== CONT  TestAccEC2AMI_basic
=== CONT  TestAccEC2Instance_basicWithSpot
=== CONT  TestAccEC2PlacementGroup_basic
--- PASS: TestAccEC2KeyPair_basic (14.21s)
--- PASS: TestAccEC2PlacementGroup_basic (14.69s)
--- PASS: TestAccEC2LaunchTemplate_basic (20.23s)
--- PASS: TestAccEC2AMI_basic (97.73s)
--- PASS: TestAccEC2Instance_basicWithSpot (130.25s)
--- PASS: TestAccEC2Instance_basic (162.53s)
--- PASS: TestAccEC2EBSSnapshotImport_basic (472.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	477.901s

ewbankkit added 12 commits July 15, 2025 16:17
@ewbankkit
tfresource.RetryWhenNewResourceNotFound: Use 'internal/retry'.
c013784
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
7719667 
…NewResourceNotFound' - appautoscaling.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
3f3cfdd 
…NewResourceNotFound' - appmesh.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
3360836 
…NewResourceNotFound' - cloudtrail.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
6540a2b 
…NewResourceNotFound' - ec2.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
4a21f2f 
…NewResourceNotFound' - ecr.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
e2c839f 
…NewResourceNotFound' - ecs.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
a8c7fef 
…NewResourceNotFound' - elbv2.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
780e539 
…NewResourceNotFound' - iam.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
2986a0c 
…NewResourceNotFound' - kms.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
b99faee 
…NewResourceNotFound' - lambda.
@ewbankkit
Add 'context.Context' arg to function called by 'tfresource.RetryWhen…
46f7af2 
…NewResourceNotFound' - sns.
@github-actions GitHub Actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/sns Issues and PRs that pertain to the sns service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/kms Issues and PRs that pertain to the kms service. service/ecr Issues and PRs that pertain to the ecr service. service/appmesh Issues and PRs that pertain to the appmesh service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/L Managed by automation to categorize the size of a PR. labels Jul 16, 2025
ewbankkit added 19 commits July 16, 2025 16:48
@github-actions github-actions bot added the client-connections Pertains to the AWS Client and service connections. label Jul 17, 2025
jar-b
jar-b approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appmesh Issues and PRs that pertain to the appmesh service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/ec2ebs Issues and PRs that pertain to the ec2ebs service. service/ec2outposts Issues and PRs that pertain to the ec2outposts service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecr Issues and PRs that pertain to the ecr service. service/ecs Issues and PRs that pertain to the ecs service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/sns Issues and PRs that pertain to the sns service. service/transitgateway Issues and PRs that pertain to the transitgateway service. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. service/vpc Issues and PRs that pertain to the vpc service. service/vpnclient Issues and PRs that pertain to the vpnclient service. service/vpnsite Issues and PRs that pertain to the vpnsite service. service/wavelength Issues and PRs that pertain to the wavelength service. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @jar-b