Skip to content

Add resource identity to aws_globalaccelerator_custom_routing_accelerator #43423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add resource identity to aws_globalaccelerator_custom_routing_accelerator #43423

wants to merge 3 commits into from

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jul 16, 2025 •
edited
Loading

Description

This PR adds resource identity support to the aws_globalaccelerator_custom_routing_accelerator resource.

Relations

Relates #42983
Relates #42984

Acceptance Test Results

--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_Basic (185.20s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_ExistingResource (191.36s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_basic (167.52s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears (174.18s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_tags (185.66s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_update (230.57s)

@jar-b
r/aws_globalaccelerator_custom_routing_accelerator: add resource iden…
e7c3362 
…tity

The acceptance test results are as follows:

--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_Basic (125.74s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_ExistingResource (122.48s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_basic (108.33s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears (103.89s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_tags (117.75s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_update (142.08s)
@github-actions GitHub Actions
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. labels Jul 16, 2025
@jar-b
r/aws_globalaccelerator_custom_routing_accelerator: use var.rName in …
26894b5 
…template

The acceptance test results are as follows:

--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_basic (167.52s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears (174.18s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_Basic (185.20s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_tags (185.66s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_ExistingResource (191.36s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_update (230.57s)
@jar-b jar-b changed the title Add resource identity to aws_globalaccelerator_custom_routing_accelerator Add resource identity to aws_globalaccelerator_custom_routing_accelerator Jul 17, 2025
@jar-b
r/aws_globalaccelerator_custom_routing_accelerator: tidy tags test te…
422c10d 
…mplate

```console
%  make testacc PKG=globalaccelerator TESTS=TestAccGlobalAcceleratorCustomRoutingAccelerator_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorCustomRoutingAccelerator_'  -timeout 360m -vet=off
2025/07/17 15:43:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:43:11 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears (113.69s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_Basic (125.07s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_ExistingResource (131.51s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_basic (137.26s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_tags (138.15s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_update (170.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  175.981s
```
@jar-b jar-b marked this pull request as ready for review July 17, 2025 19:48
@jar-b jar-b requested a review from a team as a code owner July 17, 2025 19:48
@jar-b
Copy link
Member Author

jar-b commented Jul 17, 2025 •
edited
Loading

Acceptance test results after the latest change:

%  make testacc PKG=globalaccelerator TESTS=TestAccGlobalAcceleratorCustomRoutingAccelerator_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/globalaccelerator/... -v -count 1 -parallel 20 -run='TestAccGlobalAcceleratorCustomRoutingAccelerator_'  -timeout 360m -vet=off
2025/07/17 15:43:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 15:43:11 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_disappears (113.69s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_Basic (125.07s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_Identity_ExistingResource (131.51s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_basic (137.26s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_tags (138.15s)
--- PASS: TestAccGlobalAcceleratorCustomRoutingAccelerator_update (170.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator  175.981s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jar-b