Skip to content

Add transit_gateway_attachment_id to aws_dx_gateway_association #43436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jul 17, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add the computed attribute transit_gateway_attachment_id to aws_dx_gateway_association where type is transitGateway to enable users to access this value directly without an additional datasource causing issues in dependencies between modified resources and datasources.

Relations

Closes #35009

References

Output from Acceptance Testing

% make t T='TestAccDirectConnectGatewayAssociation_' K=directconnect ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/directconnect/... -v -count 1 -parallel 4 -run='TestAccDirectConnectGatewayAssociation_'  -timeout 360m -vet=off
2025/07/18 10:04:06 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/18 10:04:06 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== PAUSE TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== RUN   TestAccDirectConnectGatewayAssociation_v1StateUpgrade
=== PAUSE TestAccDirectConnectGatewayAssociation_v1StateUpgrade
=== RUN   TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
=== RUN   TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
=== PAUSE TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
=== RUN   TestAccDirectConnectGatewayAssociation_recreateProposal
=== PAUSE TestAccDirectConnectGatewayAssociation_recreateProposal
=== CONT  TestAccDirectConnectGatewayAssociation_v0StateUpgrade
=== CONT  TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount
=== CONT  TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount
=== CONT  TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount
--- PASS: TestAccDirectConnectGatewayAssociation_basicTransitGatewayCrossAccount (1406.58s)
=== CONT  TestAccDirectConnectGatewayAssociation_recreateProposal
--- PASS: TestAccDirectConnectGatewayAssociation_v0StateUpgrade (2017.06s)
=== CONT  TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_basicVPNGatewayCrossAccount (2018.53s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewayCrossAccount (2530.29s)
=== CONT  TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount
--- PASS: TestAccDirectConnectGatewayAssociation_recreateProposal (1976.85s)
=== CONT  TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount
=== CONT  TestAccDirectConnectGatewayAssociation_v1StateUpgrade
--- PASS: TestAccDirectConnectGatewayAssociation_basicTransitGatewaySingleAccount (1377.46s)
--- PASS: TestAccDirectConnectGatewayAssociation_allowedPrefixesVPNGatewaySingleAccount (1682.20s)
--- PASS: TestAccDirectConnectGatewayAssociation_multiVPNGatewaysSingleAccount (1500.42s)
--- PASS: TestAccDirectConnectGatewayAssociation_basicVPNGatewaySingleAccount (1234.34s)
--- PASS: TestAccDirectConnectGatewayAssociation_v1StateUpgrade (1430.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      4831.026s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/directconnect Issues and PRs that pertain to the directconnect service. size/L Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Jul 17, 2025
@drewtul drewtul marked this pull request as ready for review July 17, 2025 17:28
@drewtul drewtul requested a review from a team as a code owner July 17, 2025 17:28
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 21, 2025
@ewbankkit
Copy link
Contributor

transit_gateway_attachment_id was briefly added (but never released) in 708a9e2 (#8528) to address an eventual consistency error on aws_ec2_transit_gateway delete. That was addressed in #8752.
This is a separate use case.

@ewbankkit ewbankkit self-assigned this Jul 21, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/directconnect Issues and PRs that pertain to the directconnect service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_dx_gateway_association --> tgw-attach-id output
2 participants