Skip to content

Run make gen #43743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Run make gen #43743

merged 1 commit into from
Aug 6, 2025

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 6, 2025 •
edited by jar-b
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Fixes CI check on main.

Relates #43664

@ewbankkit ewbankkit requested a review from a team as a code owner August 6, 2025 19:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/quicksight Issues and PRs that pertain to the quicksight service. generators Relates to code generators. service/logs Issues and PRs that pertain to the logs service. service/ivschat Issues and PRs that pertain to the ivschat service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/S Managed by automation to categorize the size of a PR. labels Aug 6, 2025
jar-b
jar-b approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b
Copy link
Member

jar-b commented Aug 6, 2025 •
edited
Loading

Failures on #43704 and #43736 will be resolved by this

@ewbankkit ewbankkit merged commit fe3bf2b into main Aug 6, 2025
60 checks passed
@ewbankkit ewbankkit deleted the td-make-gen branch August 6, 2025 20:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.8.0 milestone Aug 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

This functionality has been released in v6.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
generators Relates to code generators. service/ivschat Issues and PRs that pertain to the ivschat service. service/logs Issues and PRs that pertain to the logs service. service/quicksight Issues and PRs that pertain to the quicksight service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @jar-b