Skip to content

Check Read and List permissions when determining resource types #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Check Read and List permissions when determining resource types #1540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/provider/generators/allschemas/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,12 @@ func main() {
g.Errorf("parsing CloudFormation type (%s) resource schema: %s", cfTypeName, err)
}

if handler, ok := resource.Handlers[cfschema.HandlerTypeList]; ok {
// Skip resource types with no Read handler or Read handler with no permissions.
if handler, ok := resource.Handlers[cfschema.HandlerTypeRead]; !ok || len(handler.Permissions) == 0 {
continue
}

if handler, ok := resource.Handlers[cfschema.HandlerTypeList]; ok && len(handler.Permissions) > 0 {
// Ensure no required arguments.
if handlerSchema := handler.HandlerSchema; handlerSchema == nil ||
(len(handlerSchema.AllOf) == 0 && len(handlerSchema.AnyOf) == 0 && len(handlerSchema.OneOf) == 0 && len(handlerSchema.Required) == 0) {
Expand Down