Decouple the session loader into reader and writer over the cache #7108
soulomoonAnnotations
13 warnings
|
Hlint check run:
exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L437
Warning in addErrorLoadingFile in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n (error_loading_files state) (\\ xs -> (Set.insert file xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ (error_loading_files state) (Set.insert file)"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L445
Warning in removeErrorLoadingFile in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n (error_loading_files state) (\\ xs -> (Set.delete file xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ (error_loading_files state) (Set.delete file)"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L449
Warning in addCradleFiles in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef' (cradle_files state) (\\ xs -> (files <> xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ (cradle_files state) ((<>) files)"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L454
Warning in removeCradleFile in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef'\n (cradle_files state) (\\ xs -> (Set.delete file xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ (cradle_files state) (Set.delete file)"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L459
Suggestion in clearErrorLoadingFiles in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> (Set.empty, ())" ▫︎ Perhaps: "const (Set.empty, ())"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L464
Suggestion in clearCradleFiles in module Development.IDE.Session: Use const ▫︎ Found: "\\ _ -> (Set.empty, ())" ▫︎ Perhaps: "const (Set.empty, ())"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session.hs#L1100
Suggestion in newComponentCache in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(homeUnitId_ (componentDynFlags ci)) `OS.member` bad_units" ▫︎ Perhaps: "homeUnitId_ (componentDynFlags ci) `OS.member` bad_units"
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
|
|
Hlint check run:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L90
Warning in parseMultiCradleErr in module Development.IDE.Session.Diagnostics: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
|
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Hlint check run
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|