Virtio net #643
Draft
Virtio net #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 68.06% 58.56% -9.50%
==========================================
Files 20 21 +1
Lines 2311 2638 +327
==========================================
- Hits 1573 1545 -28
- Misses 738 1093 +355 ☔ View full report in Codecov by Sentry. |
|
If I get it right, using |
jounathaen
force-pushed
the
virtio-net
branch
8 times, most recently
from
ff445af to
abe8633
Compare
|
Some bugs were found when it comes to handling BARs: size/mode aren't handled correctly. I'll document progress and fix on BaderSZ#2 |
jounathaen
force-pushed
the
virtio-net
branch
3 times, most recently
from
f4b2793 to
269af79
Compare
jounathaen
force-pushed
the
virtio-net
branch
3 times, most recently
from
130b7fe to
69b95db
Compare
- renamed `init` -> `thread_local_init` - call "normal" init for x86_64::kvm_cpu during `new`. This fixes an GDB initialization issue, where virtual addresses were queried before the CR3 register was set. - removed `vcpu_init` fn, as initialization is now called either in `new` or in `run`. - call thread_local_initialization in `run_gdb` for linux. Currently this has no effect, but probably enhances consistency.
jounathaen
force-pushed
the
virtio-net
branch
2 times, most recently
from
e28b9a0 to
61a154d
Compare
- Create structs instead of using offsets into buffers. - Enhanced PCI data structure layout. - Fixes incorrect PCI Bar accesses. - Fixes bug that appeared from duplicating PCI header information in the header buffer and in other data structures as well
…r existing TAP devices
…external C code, and we can probably just use the TAP implementation for MacVTap instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and rework of #536 done by @BaderSZ
Original description:
Related: #1