HHH-19497 Test for composition of 'not' 'in' restrictions #10412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beikov would you take a look at this one please? |
beikov
reviewed
Jun 25, 2025
hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
Outdated
Show resolved
Hide resolved
michaelfranz
force-pushed
the
HHH-19497-negated-in-list
branch
from
3c5e512 to
da84610
Compare
|
Can you please rebase and squash your commits? |
michaelfranz
force-pushed
the
HHH-19497-negated-in-list
branch
from
6b5a1c7 to
48b2049
Compare
Done. |
|
@beikov quick question: Now that this contribution has been merged, what are your thoughts about creating a fix (presumably leading to a minor release) of Hibernate v6.6.x? Again, as a newbie to the Hibernate project, I'm not sure how this is usually done. Thanks. |
|
The release is automated and happens on Sunday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not in is not handled correctly for multi-column joins. This pull request fixes the problem.
Compositions of not with in on lists fail for dialects not supporting record-level construction, such as DB2Dialect.
Using not with in with such dialects can lead to dangerous outcomes, such as all records being returned from a query. This is because the query condition always evaluates to either true or false (depending on the details of the query) because multi-column joins are not handled correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19497