Replace git_data_dirs

[tobiashuste]

Starting with GitLab 18.0 git_data_dirs will be removed. They need to be replaced according to: https://docs.gitlab.com/omnibus/settings/configuration/#migrating-from-git_data_dirs

@Normo Do we want to provide a fallback for older GitLab versions? In principle the new method is now supported for quite a couple of releases.

Related to #366

[tobiashuste]

@Normo Could you please review this one?

[Normo]

@tobiashuste Thanks, that looks reasonable to me.

One thing we definitely need to consider: gitaly[‘configuration’] is also used to configure authentication and network listeners for example. So far, we have done this via the gitlab_additional_configurations variable as follows:

gitlab_additional_configurations:
  - gitaly:
      - key: ‘configuration’
        type: ‘plain’
        value: ‘{{ gitaly_configuration }}’

We need to make sure that it is merged and not overwritten.

[tobiashuste]

@tobiashuste Thanks, that looks reasonable to me.

One thing we definitely need to consider: gitaly[‘configuration’] is also used to configure authentication and network listeners for example. So far, we have done this via the gitlab_additional_configurations variable as follows:

gitlab_additional_configurations
  - gitaly:
      - key: ‘configuration’
        type: ‘plain’
        value: ‘{{ gitaly_configuration }}’

We need to make sure that it is merged and not overwritten.

That's a good point. I'll have a look how this could be done.