Multiple Parameter Lists #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPTK
reviewed
Oct 31, 2024
LPTK
reviewed
Oct 31, 2024
LPTK
reviewed
Oct 31, 2024
LPTK
reviewed
Oct 31, 2024
FlandiaYingman
changed the title
Previsouly `Apps` unapplies the tree of form `App(App(App(id: Ident, p1), p2), p3)` to `Apps(id: Ident, p1 :: p2 :: p3 :: Nil)`. Now it unapplies this as well but also `App(App(App(tree: Tree, p1), p2), p3)` to `Apps(tree: Tree, p1 :: p2 :: p3 :: Nil)`. This is especially useful for type parameters as we want to unwarp as many of layers of `App` as we can, then unwrap the `TyApp`.
LPTK
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
LGTM, thanks!
Please address my comment.
Also, it looks like I missed one file when making de0b196. To remove the inconsistency between the output of different machines, change:
-globalThis
+:slient
+globalThisin GlobalThis.mls.
The member `params` is renamed to `paramLists` to reflect its new behavior. The type of `paramLists` is changed from `Opt[Ls[Tree]]` to `Ls[Tup]` to reflect its new behavior. It now returns a list of parameter tuples instead of a list of parameters.
|
Done |
|
What. There are no changes printed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.