Skip to content

The Ultimate Pattern Syntax #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Aug 12, 2025
Merged

The Ultimate Pattern Syntax #316

merged 66 commits into from
Aug 12, 2025

Conversation

chengluyu
Copy link
Member

No description provided.

@FlandiaYingman FlandiaYingman mentioned this pull request Aug 10, 2025
@chengluyu
Copy link
Member Author

Alright, I've fixed most of the issues in this PR. Let's merge it so #325 won’t be blocked.

Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, finally LGTM, tho I still have a few questions and minor chnage requests.

@chengluyu
Copy link
Member Author

By the way, why is the test folder called rp? Why not ups?

At that time, we hadn’t called it ups yet. I just renamed the entire test folder. Let’s merge it!

@LPTK
Copy link
Contributor

LPTK commented Aug 12, 2025

Let’s merge it!

Yes, after you rever the symbol-checkign logic mentioned above.

@LPTK LPTK merged commit 94345cb into hkust-taco:hkmc2 Aug 12, 2025
1 check passed
@LPTK LPTK deleted the ups branch August 12, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants