-
Notifications
You must be signed in to change notification settings - Fork 34
The Ultimate Pattern Syntax #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/Normalization.scala
Outdated
Show resolved
Hide resolved
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/Translator.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
Alright, I've fixed most of the issues in this PR. Let's merge it so #325 won’t be blocked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, finally LGTM, tho I still have a few questions and minor chnage requests.
hkmc2/shared/src/main/scala/hkmc2/semantics/ucs/Normalization.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Lionel Parreaux <[email protected]>
At that time, we hadn’t called it ups yet. I just renamed the entire test folder. Let’s merge it! |
Yes, after you rever the symbol-checkign logic mentioned above. |
No description provided.