Project specific ODK form

[NSUWAL123]

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation
• 🧑‍💻 Refactor
• ✅ Test
• 🤖 Build or CI
• ❓ Other (please specify)

Related Issue

• Related to The option to choose between ODK Collect and Webform is not functional #2488

Describe this PR

• Display webforms or allow users to use Othe DK app based on project settings
• Remove enableWebforms from config.json with implementation of project-specific ODK

Screenshots

[spwoodcock]

The values are here as examples, plus this is the default file if no config in S3.

I think we will need
enableWebforms: true

[NSUWAL123]

Since we are using the value of use_odk_collect from the project API, why do we need this?

[spwoodcock]

I think there is a misunderstanding on the use of both vars:

• enableWebforms is per instance of fieldtm (its a feature flag to enable web forms functionality, else the instance uses ODK Collect for every project (ignore use_odk_collect)
• The use_odk_collect param is per project and is an override. Its anticipated that most uses use web forms, but its good to have an override if necessary (web forms has some missing form functionality)

[NSUWAL123]

I think I finally got your point:
You mean that if enableWebforms is false, though setting the use_odk_collect to false during project creation, we don't show webforms because we have disabled the feature of webforms in that particular instance.

And if enableWebforms is true, the user can override the behaviour of using webforms by setting the user_odk_collect to true, and the user can use ODK Collect instead of webforms.

[NSUWAL123]

Also, there seems to be a bug with this condition:

if (project.use_odk_collect) {
    commonStore.setUseOdkCollectOverride(project.use_odk_collect);
}

What's happening here is, the initial state of useOdkCollectOverride is false, when a project with use_odk_collect set to true is opened, then the useOdkCollectOverride is set to true. Now if a user then opens a project where use_odk_collect set to false, the state of useOdkCollectOverride is not updated to false, due to which only mapping through ODK app is set.

[spwoodcock]

data doesn't need derived I don't think, but I think the recommended Svelte way is prop destructuring

const { project } = data

[spwoodcock]

Not 100% on this, but I think all reactive svelte vars should use let and not const

[NSUWAL123]

Forgot to switch the branch. This PR is also related to:

• Newly created polygons are stored below tasks and existing features layers #2352 (new-geom, bad-geom etc layers vanish on baselayer switch)
• The submission_ids field is not saved from submission XML to the entity property (+ other related issues) #2493 (UI crash when try to validate the submission from project-details page)