Skip to content

Option to delete newly created entity #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Jun 10, 2025
Merged

Option to delete newly created entity #2506

merged 50 commits into from
Jun 10, 2025

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented May 13, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • Entity deletion from management frontend (Project manager or higher level access)
  • Entity deletion from mapper frontend (the person who created the entity)

Screenshots

Delete entity from management
https://github.com/user-attachments/assets/4e2a9a0a-fcb8-460b-a1a5-2ada3c2f3798

Delete entity from mapper
https://github.com/user-attachments/assets/b78c1cc3-bf6b-4ac5-acc6-22a882d77da6

If someone other than the entity creator tries to delete the feature
image

@github-actions github-actions bot added enhancement New feature or request frontend:mapper Related to the mapper frontend code labels May 13, 2025
@github-actions github-actions bot added the frontend:management Related to the management frontend code label May 13, 2025
@NSUWAL123
Copy link
Contributor Author

Action on backend:

  • Currently geomrecord can only be deleted by PM or of higher lever. So now we also want the user who created the entity to delete the entity.
  • Api to delete entity from central

CC: @Anuj-Gupta4

@NSUWAL123 NSUWAL123 mentioned this pull request May 14, 2025
Closed
@spwoodcock spwoodcock mentioned this pull request May 15, 2025
Merged
11 tasks
@Anuj-Gupta4
Copy link
Collaborator

Anuj-Gupta4 commented May 16, 2025 •
edited
Loading

There is updated code for this on:

#2525

This branch will need to be rebased after that pull request is merged.

@NSUWAL123
Copy link
Contributor Author

/central/entity throwing a 500 error when passing user_sub on feature property while creating a new entity.
image
image

@NSUWAL123 NSUWAL123 deployed to 2506/merge June 2, 2025 05:36 — with GitHub Actions Active
@NSUWAL123 NSUWAL123 marked this pull request as ready for review June 2, 2025 06:10
@NSUWAL123 NSUWAL123 requested a review from spwoodcock June 2, 2025 06:10
spwoodcock
spwoodcock approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, but this will require someone to run the migration on dev / stage / prod if merged in 👍 (otherwise I'll do when I'm back)

@Sujanadh Sujanadh merged commit a3c6f61 into development Jun 10, 2025
8 of 9 checks passed
@Sujanadh Sujanadh deleted the feat/del-new-entity branch June 10, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

@Sujanadh Sujanadh Sujanadh approved these changes

@Anuj-Gupta4 Anuj-Gupta4 Awaiting requested review from Anuj-Gupta4

Assignees
No one assigned
Labels
backend Related to backend code dependency:osm-fieldwork Requires updates in osm-fieldwork enhancement New feature or request frontend:management Related to the management frontend code frontend:mapper Related to the mapper frontend code migration Contains a DB migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NSUWAL123 @Anuj-Gupta4 @spwoodcock @Sujanadh