-
-
Notifications
You must be signed in to change notification settings - Fork 63
Feat roadways issue fix #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat roadways issue fix #2571
Conversation
for more information, see https://pre-commit.ci
@Anuj-Gupta4 i am having an issue on the PR. It seems to be from the previous merge, as suggested by @Sujanadh. Can you have a look and try to fix this check fail? Let me and @manjitapandey know if it gets fixed, and please merge it if you can so that manjita can see the changes. |
β¦ feat-roadways-issue-fix
for more information, see https://pre-commit.ci
A couple of things to address:
|
β¦ING and MULTILINESTRING
β¦rate line feature style
Line Geometry Visualization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well enough. We can hide the task split option when lines are selected for mapping in a separate pr.
|
Agree - linestrings need another type of splitting algorithm entirely - maybe sometime in the future π |
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
Worked on the provided geojson of Tommy Charles in the hotosm slack which now helps the user to map roadways aswell
NOTE: Still need some code to work on osm data extract for road, which i can do later on.
Screenshots
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?