Skip to content

Feat roadways issue fix #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 4, 2025
Merged

Feat roadways issue fix #2571

merged 38 commits into from
Jun 4, 2025

Conversation

varun2948
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

Worked on the provided geojson of Tommy Charles in the hotosm slack which now helps the user to map roadways aswell

  • Fix project creation based on outside geojson for road / Linestring layers.
  • Fix data-extract not showing up on both frontend because of the lack in styling of "Linestring"
  • Added one migration to add enum for Linestring on geomtype which was missing.

NOTE: Still need some code to work on osm data extract for road, which i can do later on.

Screenshots

Review Guide

Notes for the reviewer. How to test this change?

  • Create a new project based on roadways line string with custom data extract not generating data extract

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@varun2948 varun2948 requested a review from spwoodcock May 30, 2025 04:43
@github-actions github-actions bot added bug Something isn't working enhancement New feature or request frontend:management Related to the management frontend code backend Related to backend code migration Contains a DB migration frontend:mapper Related to the mapper frontend code labels May 30, 2025
@varun2948
Copy link
Contributor Author

@Anuj-Gupta4 i am having an issue on the PR. It seems to be from the previous merge, as suggested by @Sujanadh. Can you have a look and try to fix this check fail? Let me and @manjitapandey know if it gets fixed, and please merge it if you can so that manjita can see the changes.

@Anuj-Gupta4
Copy link
Collaborator

Anuj-Gupta4 commented Jun 2, 2025

A couple of things to address:

  1. Task Splitter & Geometry
    Task splitting does not currently work for LINESTRING. The available options in the project area split section should dynamically change based on the selected geometry type.

  2. Project
    Projects should be:

@NSUWAL123 NSUWAL123 mentioned this pull request Jun 3, 2025
11 tasks
@NSUWAL123 NSUWAL123 requested a review from spwoodcock June 4, 2025 06:58
Copy link
Collaborator

@Anuj-Gupta4 Anuj-Gupta4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well enough. We can hide the task split option when lines are selected for mapping in a separate pr.

@Anuj-Gupta4 Anuj-Gupta4 merged commit b84cdde into development Jun 4, 2025
9 checks passed
@Anuj-Gupta4 Anuj-Gupta4 deleted the feat-roadways-issue-fix branch June 4, 2025 08:11
@Sujanadh
Copy link
Collaborator

Sujanadh commented Jun 5, 2025

A couple of things to address:

  1. Task Splitter & Geometry
    Task splitting does not currently work for LINESTRING. The available options in the project area split section should dynamically change based on the selected geometry type.

  2. Project
    Projects should be:

  1. If the primary geom type is linestring, we can still retrieve all the polygon features from OSM while task splitting and split the area of interest based on the number of features.
  2. But option 1 doesn't seem feasible in the case of a linestring, as we split the area based on the linear features present. So splitting while using linestring as the primary geom type doesn't make sense at all. For this we can simply avoid the options to split during project creation.

@spwoodcock
Copy link
Member

Agree - linestrings need another type of splitting algorithm entirely - maybe sometime in the future πŸ˜ƒ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working enhancement New feature or request frontend:management Related to the management frontend code frontend:mapper Related to the mapper frontend code migration Contains a DB migration tests Related to automated code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants