Skip to content

feat(lts/transfer): the resource supports new fields #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:
Supports new fields:

  • new parameters in log_transfer_info.log_transfer_detail structure: invalid_field_value, lts_tags, stream_tags, and struct_fields.
  • new attribute: created_at.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o lts -f TestAccTransfer_
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccTransfer_ -timeout 360m -parallel 10
=== RUN   TestAccTransfer_basic
=== PAUSE TestAccTransfer_basic
=== RUN   TestAccTransfer_dis
=== PAUSE TestAccTransfer_dis
=== RUN   TestAccTransfer_agency
=== PAUSE TestAccTransfer_agency
=== RUN   TestAccTransfer_dms
=== PAUSE TestAccTransfer_dms
=== CONT  TestAccTransfer_basic
=== CONT  TestAccTransfer_agency
=== CONT  TestAccTransfer_dms
=== CONT  TestAccTransfer_dis
--- PASS: TestAccTransfer_dis (60.76s)
--- PASS: TestAccTransfer_dms (61.27s)
--- PASS: TestAccTransfer_basic (64.02s)
--- PASS: TestAccTransfer_agency (100.48s)
PASS
coverage: 10.5% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       100.764s        coverage: 10.5% of statements in ./huaweicloud/services/lts
./scripts/coverage.sh -o lts -f TestAccDatasourceTransfers_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccDatasourceTransfers_basic -timeout 360m -parallel 10
=== RUN   TestAccDatasourceTransfers_basic
=== PAUSE TestAccDatasourceTransfers_basic
=== CONT  TestAccDatasourceTransfers_basic
--- PASS: TestAccDatasourceTransfers_basic (31.14s)
PASS
coverage: 10.8% of statements in ./huaweicloud/services/lts
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts       31.236s coverage: 10.8% of statements in ./huaweicloud/services/lts
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong force-pushed the lts_log_transfer branch 2 times, most recently from 2ac30da to cc7e7ee Compare June 4, 2025 01:11
@Alice1319
Copy link

LGTM

@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o lts -f TestAccTransfer_
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/lts" -v -coverprofile="./huaweicloud/services/acceptance/lts/lts_coverage.cov" -coverpkg="./huaweicloud/services/lts" -run TestAccTransfer_ -timeout 360m -parallel 10
=== RUN TestAccTransfer_basic
=== PAUSE TestAccTransfer_basic
=== RUN TestAccTransfer_dis
=== PAUSE TestAccTransfer_dis
=== RUN TestAccTransfer_agency
=== PAUSE TestAccTransfer_agency
=== RUN TestAccTransfer_dms
=== PAUSE TestAccTransfer_dms
=== CONT TestAccTransfer_basic
=== CONT TestAccTransfer_dms
=== CONT TestAccTransfer_dis
=== CONT TestAccTransfer_agency
--- PASS: TestAccTransfer_dms (60.75s)
--- PASS: TestAccTransfer_dis (60.97s)
--- PASS: TestAccTransfer_basic (64.37s)
--- PASS: TestAccTransfer_agency (97.73s)
PASS
coverage: 10.5% of statements in ./huaweicloud/services/lts
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/lts 97.992s coverage: 10.5% of statements in ./huaweicloud/services/lts

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 114bb87 into huaweicloud:master Jun 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants