Skip to content

feat(apig): add new data source to query instances by tags #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:
Add new data source(huaweicloud_apig_instances_filter) to query instances.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new data source.
2. add corresponding document and acceptance test.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o apig -f TestAccDataSourceInstancesFilter_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/apig" -v -coverprofile="./huaweicloud/services/acceptance/apig/apig_coverage.cov" -coverpkg="./huaweicloud/services/apig" -run TestAccDataSourceInstancesFilter_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceInstancesFilter_basic
=== PAUSE TestAccDataSourceInstancesFilter_basic
=== CONT  TestAccDataSourceInstancesFilter_basic
--- PASS: TestAccDataSourceInstancesFilter_basic (520.51s)
PASS
coverage: 4.3% of statements in ./huaweicloud/services/apig
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      520.764s        coverage: 4.3% of statements in ./huaweicloud/services/apig

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@luoping-12345
Copy link
Contributor

LGTM

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit e0d1dd2 into huaweicloud:master Jun 30, 2025
14 checks passed
@wuzhuanhong wuzhuanhong deleted the apig_by_tag_filter_instance branch July 3, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants