Skip to content

feat(workspace): add new data source query policy groups #7099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

feat(workspace): add new data source query policy groups #7099

merged 1 commit into from
Jul 3, 2025

Conversation

946596029
Copy link
Contributor

@946596029 946596029 commented Jun 26, 2025 •
edited
Loading

What this PR does / why we need it:
feat(workspace): add new data source query policy groups

Which issue this PR fixes:
nothing

Special notes for your reviewer:
nothing

Release note:

1. implement provider
2. add test case
3. add document

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourcePolicyGroups_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourcePolicyGroups_basic
--- PASS: TestAccDataSourcePolicyGroups_basic (118.50s)
PASS
coverage: 6.3% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 118.608s        coverage: 6.3% of statements in ./huaweicloud/services/workspace

image

  • Documentation updated.
  • Schema updated.
  • CheckDeleted.

@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch 6 times, most recently from 558d8aa to 15831b3 Compare June 27, 2025 01:59
@946596029
Copy link
Contributor Author

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourcePolicyGroups_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourcePolicyGroups_basic
--- PASS: TestAccDataSourcePolicyGroups_basic (124.06s)
PASS
coverage: 6.3% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 124.164s coverage: 6.3% of statements in ./huaweicloud/services/workspace

@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch 3 times, most recently from 6aabc75 to fec2e3c Compare June 30, 2025 12:11
@946596029
Copy link
Contributor Author

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourcePolicyGroups_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourcePolicyGroups_basic
--- PASS: TestAccDataSourcePolicyGroups_basic (116.55s)
PASS
coverage: 6.3% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 116.656s coverage: 6.3% of statements in ./huaweicloud/services/workspace

@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch 2 times, most recently from 3228d36 to e7d0db1 Compare June 30, 2025 12:39
Lance52259
Lance52259 reviewed Jun 30, 2025
View reviewed changes
Lance52259
Lance52259 reviewed Jun 30, 2025
View reviewed changes
@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch from e7d0db1 to c2206ef Compare July 2, 2025 09:02
wuzhuanhong
wuzhuanhong reviewed Jul 2, 2025
View reviewed changes
@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch 2 times, most recently from bf046ef to b2686a0 Compare July 3, 2025 02:20
@946596029
Copy link
Contributor Author

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourcePolicyGroups_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourcePolicyGroups_basic
--- PASS: TestAccDataSourcePolicyGroups_basic (119.34s)
PASS
coverage: 6.2% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 119.481s coverage: 6.2% of statements in ./huaweicloud/services/workspace

@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch from b2686a0 to 30d91aa Compare July 3, 2025 04:02
@946596029
Copy link
Contributor Author

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourcePolicyGroups_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourcePolicyGroups_basic
--- PASS: TestAccDataSourcePolicyGroups_basic (121.24s)
PASS
coverage: 6.2% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 121.370s coverage: 6.2% of statements in ./huaweicloud/services/workspace

@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch 2 times, most recently from 9ba7dec to 2e66f2b Compare July 3, 2025 09:35
@946596029
Copy link
Contributor Author

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourcePolicyGroups_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourcePolicyGroups_basic
--- PASS: TestAccDataSourcePolicyGroups_basic (119.00s)
PASS
coverage: 6.2% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 119.112s coverage: 6.2% of statements in ./huaweicloud/services/workspace

@946596029 946596029 force-pushed the br_workspace_policy_groups_datasource branch from 2e66f2b to 66c85c2 Compare July 3, 2025 09:40
@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2025
github-ci-robot
github-ci-robot approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 6bab208 into huaweicloud:master Jul 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance52259 Lance52259 Lance52259 left review comments

@wuzhuanhong wuzhuanhong wuzhuanhong left review comments

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@946596029 @Lance52259 @wuzhuanhong @github-ci-robot