Skip to content

feat(secmaster): add datasource to get list of playbook review result #7103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

ruwenqiang123
Copy link
Contributor

@ruwenqiang123 ruwenqiang123 commented Jun 26, 2025

What this PR does / why we need it:

Add datasource to get list of playbook review result.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
$ bash test.sh "./huaweicloud/services/acceptance/secmaster" "TestAccDataSourcePlaybookApprovals_basic"
TF_ACC=1 go test ./huaweicloud/services/acceptance/secmaster -run TestAccDataSourcePlaybookApprovals_basic -timeout 360m -parallel 4

=== RUN   TestAccDataSourcePlaybookApprovals_basic
=== PAUSE TestAccDataSourcePlaybookApprovals_basic
=== CONT  TestAccDataSourcePlaybookApprovals_basic
--- PASS: TestAccDataSourcePlaybookApprovals_basic (15.33s)
PASS
coverage: 2.6% of statements in ./huaweicloud/...
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/secmaster 15.820s coverage: 2.6% of statements in ./huaweicloud/...

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@luoping-12345
Copy link
Contributor

LGTM

1 similar comment
@dengyali0125
Copy link

LGTM

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 543ac38 into huaweicloud:master Jul 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants