Skip to content

Conversation

liquid-liquid
Copy link
Contributor

@liquid-liquid liquid-liquid commented Aug 15, 2025

What this PR does / why we need it:
Supports new data source to get kms key tags and names huaweicloud_kms_key_tags.
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/dew" -v -coverprofile="./huaweicloud/services/acceptance/dew/dew_coverage.cov" -coverpkg="./huaweicloud/services/dew" -run TestAccDataSourceKmsKeyTags_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceKmsKeyTags_basic
=== PAUSE TestAccDataSourceKmsKeyTags_basic
=== CONT  TestAccDataSourceKmsKeyTags_basic
--- PASS: TestAccDataSourceKmsKeyTags_basic (10.44s)
PASS
coverage: 3.7% of statements in ./huaweicloud/services/dew
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dew       10.467s coverage: 3.7% of statements in ./huaweicloud/services/dew
image
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@liquid-liquid liquid-liquid force-pushed the dew_kms_tags branch 3 times, most recently from 3344e6f to 36cc9b2 Compare August 21, 2025 07:54
@liquid-liquid liquid-liquid force-pushed the dew_kms_tags branch 4 times, most recently from 6587914 to e84ede4 Compare August 21, 2025 08:03
@liquid-liquid liquid-liquid changed the title feat(dew): add a datasource to query the tag list of KMS feat(dew): add a datasource to query the list of KMS key tags Aug 21, 2025
@liquid-liquid liquid-liquid force-pushed the dew_kms_tags branch 2 times, most recently from 74871cf to e336931 Compare August 22, 2025 02:31
@ruwenqiang123
Copy link
Contributor

LGTM

@liquid-liquid
Copy link
Contributor Author

liquid-liquid commented Aug 28, 2025

image

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/dew" -v -coverprofile="./huaweicloud/services/acceptance/dew/dew_coverage.cov" -coverpkg="./huaweicloud/services/dew" -run TestAccDataSourceKmsKeyTags_basic -timeout 360m -parallel 10
=== RUN TestAccDataSourceKmsKeyTags_basic
=== PAUSE TestAccDataSourceKmsKeyTags_basic
=== CONT TestAccDataSourceKmsKeyTags_basic
--- PASS: TestAccDataSourceKmsKeyTags_basic (27.55s)
PASS
coverage: 3.8% of statements in ./huaweicloud/services/dew
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dew 27.629s coverage: 3.8% of statements in ./huaweicloud/services/dew

@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 6e6a21d into huaweicloud:master Aug 28, 2025
4 checks passed
@liquid-liquid liquid-liquid deleted the dew_kms_tags branch August 29, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants