-
Notifications
You must be signed in to change notification settings - Fork 194
feat(dew): add a datasource to query the list of KMS key tags #7532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
github-ci-robot
merged 1 commit into
huaweicloud:master
from
liquid-liquid:dew_kms_tags
Aug 28, 2025
Merged
feat(dew): add a datasource to query the list of KMS key tags #7532
github-ci-robot
merged 1 commit into
huaweicloud:master
from
liquid-liquid:dew_kms_tags
Aug 28, 2025
+198
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnzr123
reviewed
Aug 15, 2025
787ebb1
to
2b95bb7
Compare
jnzr123
reviewed
Aug 21, 2025
3344e6f
to
36cc9b2
Compare
6587914
to
e84ede4
Compare
huaweicloud/services/acceptance/dew/data_source_huaweicloud_kms_tags_test.go
Outdated
Show resolved
Hide resolved
huaweicloud/services/acceptance/dew/data_source_huaweicloud_kms_tags_test.go
Outdated
Show resolved
Hide resolved
huaweicloud/services/acceptance/dew/data_source_huaweicloud_kms_tags_test.go
Outdated
Show resolved
Hide resolved
e84ede4
to
109417e
Compare
74871cf
to
e336931
Compare
LGTM |
deer-hang
reviewed
Aug 27, 2025
huaweicloud/services/acceptance/dew/data_source_huaweicloud_kms_key_tags_test.go
Show resolved
Hide resolved
deer-hang
reviewed
Aug 27, 2025
huaweicloud/services/dew/data_source_huaweicloud_kms_key_tags.go
Outdated
Show resolved
Hide resolved
e336931
to
560b822
Compare
560b822
to
77f7abf
Compare
/approve |
github-ci-robot
approved these changes
Aug 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been approved by: @deer-hang
/approve
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Supports new data source to get kms key tags and names huaweicloud_kms_key_tags.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Documentation updated.
Schema updated.
CheckDeleted.
a. During query operation (Read Context)
aa. Resource not found
>>>>>> Paste the screenshot here <<<<<<
b. During delete/disassociate/unbind operation (Delete Context)
ba. Resource not found
>>>>>> Paste the screenshot here <<<<<<