Skip to content

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add a new parameter tls_mode.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
 ./scripts/coverage.sh -o rocketmq -f TestAccDmsRocketM
QInstance_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/rocketmq" -v -coverprofile="./huaweicloud/services/acceptance/rocketmq/rocketmq_coverage.cov" -coverpkg="./huaweicloud/services/rocketmq" -run TestAccDmsRocketMQInstance_basic -timeout 360m -parallel 10
=== RUN   TestAccDmsRocketMQInstance_basic
=== PAUSE TestAccDmsRocketMQInstance_basic
=== CONT  TestAccDmsRocketMQInstance_basic
--- PASS: TestAccDmsRocketMQInstance_basic (2514.49s)
PASS
coverage: 20.9% of statements in ./huaweicloud/services/rocketmq
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rocketmq      2514.568s coverage: 20.9% of statements in ./huaweicloud/services/rocketmq
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o rocketmq -f TestAccDmsRocketMQInstance_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/rocketmq" -v -coverprofile="./huaweicloud/services/acceptance/rocketmq/rocketmq_coverage.cov" -coverpkg="./huaweicloud/services/rocketmq" -run TestAccDmsRocketMQInstance_basic -timeout 360m -parallel 10
=== RUN TestAccDmsRocketMQInstance_basic
=== PAUSE TestAccDmsRocketMQInstance_basic
=== CONT TestAccDmsRocketMQInstance_basic
--- PASS: TestAccDmsRocketMQInstance_basic (2509.46s)
PASS
coverage: 20.8% of statements in ./huaweicloud/services/rocketmq
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rocketmq 2509.524s coverage: 20.8% of statements in ./huaweicloud/services/rocketmq

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 837f005 into huaweicloud:master Aug 25, 2025
12 checks passed
@wuzhuanhong wuzhuanhong deleted the tls_mode branch August 26, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants