Skip to content

feat(eg): add new batch operation resource for event subscriptions #7599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

feat(eg): add new batch operation resource for event subscriptions #7599

merged 1 commit into from
Aug 25, 2025

Conversation

946596029
Copy link
Contributor

@946596029 946596029 commented Aug 21, 2025 •
edited
Loading

What this PR does / why we need it:
feat(eg): add new batch operation resource for event subscriptions

Which issue this PR fixes:
nothing

Special notes for your reviewer:
nothing

Release note:

1. add provider implement
2. add test case
3. add document

PR Checklist

  • Tests added/passed.
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/eg" -v -coverprofile="./huaweicloud/services/acceptance/eg/eg_coverage.cov" -coverpkg="./huaweicloud/services/eg" -run TestAccEventSubscriptionAction_basic -timeout 360m -parallel 10
=== RUN   TestAccEventSubscriptionAction_basic
=== PAUSE TestAccEventSubscriptionAction_basic
=== CONT  TestAccEventSubscriptionAction_basic
--- PASS: TestAccEventSubscriptionAction_basic (22.21s)
PASS
coverage: 5.5% of statements in ./huaweicloud/services/eg
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eg        22.303s coverage: 5.5% of statements in ./huaweicloud/services/eg
image
  • Documentation updated.
  • Schema updated.
  • CheckDeleted.

@github-ci-robot github-ci-robot added the needs-rebase This branch has conflicts that must be resolved. label Aug 21, 2025
@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch from e965d7d to 8c01e29 Compare August 21, 2025 08:03
@github-ci-robot github-ci-robot removed the needs-rebase This branch has conflicts that must be resolved. label Aug 21, 2025
@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch 2 times, most recently from 2ca82c6 to df67fd5 Compare August 21, 2025 08:21
@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch 3 times, most recently from 932717e to bd82033 Compare August 21, 2025 11:35
@946596029
Copy link
Contributor Author

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/eg" -v -coverprofile="./huaweicloud/services/acceptance/eg/eg_coverage.cov" -coverpkg="./huaweicloud/services/eg" -run TestAccEventSubscriptionBatchAction_basic -timeout 360m -parallel 10
=== RUN TestAccEventSubscriptionBatchAction_basic
=== PAUSE TestAccEventSubscriptionBatchAction_basic
=== CONT TestAccEventSubscriptionBatchAction_basic
--- PASS: TestAccEventSubscriptionBatchAction_basic (26.19s)
PASS
coverage: 5.5% of statements in ./huaweicloud/services/eg
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eg 26.282s coverage: 5.5% of statements in ./huaweicloud/services/eg

@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch 2 times, most recently from 2cd9580 to eb3adc8 Compare August 25, 2025 08:02
@github-ci-robot github-ci-robot added the needs-rebase This branch has conflicts that must be resolved. label Aug 25, 2025
@github-ci-robot
Copy link
Collaborator

This PR needs rebase.

@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch from eb3adc8 to 177fefd Compare August 25, 2025 09:21
@github-ci-robot github-ci-robot removed the needs-rebase This branch has conflicts that must be resolved. label Aug 25, 2025
@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch 6 times, most recently from d7b666d to dc93eea Compare August 25, 2025 12:58
@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch from dc93eea to 0f0b5cd Compare August 25, 2025 13:08
@946596029 946596029 force-pushed the br_eg_event_subscription_operation branch from 0f0b5cd to 7bbb308 Compare August 25, 2025 13:13
@946596029 946596029 changed the title feat(eg): add new operation resource for event subscription feat(eg): add new operation resource for event subscriptions Aug 25, 2025
@946596029 946596029 changed the title feat(eg): add new operation resource for event subscriptions feat(eg): add new batch operation resource for event subscriptions Aug 25, 2025
@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2025
github-ci-robot
github-ci-robot approved these changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit b0fb44d into huaweicloud:master Aug 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

+1 more reviewer

@Lance52259 Lance52259 Lance52259 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@946596029 @github-ci-robot @Lance52259